From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757390Ab2BHTFp (ORCPT ); Wed, 8 Feb 2012 14:05:45 -0500 Received: from merlin.infradead.org ([205.233.59.134]:37084 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757354Ab2BHTFn (ORCPT ); Wed, 8 Feb 2012 14:05:43 -0500 Message-ID: <4F32C744.9050400@kernel.dk> Date: Wed, 08 Feb 2012 20:04:36 +0100 From: Jens Axboe MIME-Version: 1.0 To: Stanislaw Gruszka CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] bsg: fix sysfs link remove warning References: <20120208172306.GA2301@redhat.com> In-Reply-To: <20120208172306.GA2301@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2012 06:23 PM, Stanislaw Gruszka wrote: > We create "bsg" link if q->kobj.sd is not NULL, so remove it only > when the same condition is true. > > Fixes: > > WARNING: at fs/sysfs/inode.c:323 sysfs_hash_and_remove+0x2b/0x77() > sysfs: can not remove 'bsg', no directory > Call Trace: > [] warn_slowpath_common+0x6a/0x7f > [] ? sysfs_hash_and_remove+0x2b/0x77 > [] warn_slowpath_fmt+0x2b/0x2f > [] sysfs_hash_and_remove+0x2b/0x77 > [] sysfs_remove_link+0x20/0x23 > [] bsg_unregister_queue+0x40/0x6d > [] __scsi_remove_device+0x31/0x9d > [] scsi_forget_host+0x41/0x52 > [] scsi_remove_host+0x71/0xe0 > [] quiesce_and_remove_host+0x51/0x83 [usb_storage] > [] usb_stor_disconnect+0x18/0x22 [usb_storage] > [] usb_unbind_interface+0x4e/0x109 > [] __device_release_driver+0x6b/0xa6 > [] device_release_driver+0x17/0x22 > [] bus_remove_device+0xd6/0xe6 > [] device_del+0xf2/0x137 > [] usb_disable_device+0x94/0x1a0 > > Signed-off-by: Stanislaw Gruszka Thanks, applied. -- Jens Axboe