From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RvDpc-0005lg-5P
	for mharc-grub-devel@gnu.org; Wed, 08 Feb 2012 15:09:32 -0500
Received: from eggs.gnu.org ([140.186.70.92]:53957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvDpY-0005YD-EL
	for grub-devel@gnu.org; Wed, 08 Feb 2012 15:09:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvDpX-0004mZ-8X
	for grub-devel@gnu.org; Wed, 08 Feb 2012 15:09:28 -0500
Received: from mail-we0-f169.google.com ([74.125.82.169]:52743)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvDpX-0004mT-3q
	for grub-devel@gnu.org; Wed, 08 Feb 2012 15:09:27 -0500
Received: by wera13 with SMTP id a13so858852wer.0
	for <grub-devel@gnu.org>; Wed, 08 Feb 2012 12:09:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=DZXGidlkoRl90V0Lm1mdNMJAgzO7c4Qt86Md+c6decA=;
	b=FbWj/HZNAiceEBZEkeN7DXFbKxYXTwPujvMxkY9c3Zdiu5Y0RGa8wGWNu/xpXndWjX
	uUA3cTpdkxyxzvcDmOnnEm1kDPgG01esN9HHka1SRDwfvQuk+HCLHrBz2CptT7Ucyua9
	ESBL0BOrA4JkKROEBmGG2ESSP1a+E7kQ5DXrE=
Received: by 10.216.138.195 with SMTP id a45mr1627835wej.25.1328731766504;
	Wed, 08 Feb 2012 12:09:26 -0800 (PST)
Received: from debian.x201.phnet (202-41.62-81.cust.bluewin.ch. [81.62.41.202])
	by mx.google.com with ESMTPS id m8sm714405wia.11.2012.02.08.12.09.24
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 08 Feb 2012 12:09:25 -0800 (PST)
Message-ID: <4F32D673.2070402@gmail.com>
Date: Wed, 08 Feb 2012 21:09:23 +0100
From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?=
	<phcoder@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0
MIME-Version: 1.0
To: Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 2/4] Add grub_efi_get_variable
References: <1328719918-4789-1-git-send-email-mjg@redhat.com>
	<1328719918-4789-3-git-send-email-mjg@redhat.com>
	<4F32D33B.80000@gmail.com> <20120208200434.GA7865@srcf.ucam.org>
In-Reply-To: <20120208200434.GA7865@srcf.ucam.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 74.125.82.169
Cc: The development of GNU GRUB <grub-devel@gnu.org>
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2012 20:09:30 -0000

On 08.02.2012 21:04, Matthew Garrett wrote:
> On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> +  for (i=0; i<(int)grub_strlen((char *)var); i++)
>>> +    var16[i] = var[i];
>>> +  var16[i] = '\0';
>>> +
>> We use grub_utf8_to_utf16. Also don't forget to multiply the malloc
>> length by GRUB_MAX_UTF16_PER_UTF8 ((GRUB_MAX_UTF16_PER_UTF8 * length
>> + 1) * sizeof (var16[0]))
> That's not currently exported. Any problem with changing that?
It already is. The prototype and the define is in grub/charset.h


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko