From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RvFuZ-0003xl-Ae
	for mharc-grub-devel@gnu.org; Wed, 08 Feb 2012 17:22:47 -0500
Received: from eggs.gnu.org ([140.186.70.92]:55798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvFuW-0003xd-T0
	for grub-devel@gnu.org; Wed, 08 Feb 2012 17:22:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvFuV-0006l7-N5
	for grub-devel@gnu.org; Wed, 08 Feb 2012 17:22:44 -0500
Received: from mail-wi0-f169.google.com ([209.85.212.169]:34794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RvFuV-0006kv-EA
	for grub-devel@gnu.org; Wed, 08 Feb 2012 17:22:43 -0500
Received: by wibhj13 with SMTP id hj13so977313wib.0
	for <grub-devel@gnu.org>; Wed, 08 Feb 2012 14:22:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=K5LHjE5m7jgBCc9ol/T+5FlvcTIYP20zGN+gCBLilDk=;
	b=NekTqalWhqU/if+jgArD4OhSem4LOEnlLlnXRDgDvfNkJYEUmnRxcFuvx/p1lpgOT1
	hegJ3qfJDYJyHtDFxqfVjeEXj84k1mXKRtRmxY1ZR/3zQryklacYeN636qCoaRb5Sd3y
	vC122dFGeRSspnQc52XG1zj5QdFR1GgTaXxxA=
Received: by 10.180.86.198 with SMTP id r6mr29407989wiz.2.1328739762541;
	Wed, 08 Feb 2012 14:22:42 -0800 (PST)
Received: from debian.x201.phnet (62-62.203-62.cust.bluewin.ch. [62.203.62.62])
	by mx.google.com with ESMTPS id y6sm2836269wix.10.2012.02.08.14.22.40
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 08 Feb 2012 14:22:41 -0800 (PST)
Message-ID: <4F32F5A8.9080009@gmail.com>
Date: Wed, 08 Feb 2012 23:22:32 +0100
From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?=
	<phcoder@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH V3 2/3] Add support for avoiding firmware in relocations
References: <1328720102-4914-1-git-send-email-mjg@redhat.com>
	<1328720102-4914-2-git-send-email-mjg@redhat.com>
In-Reply-To: <1328720102-4914-2-git-send-email-mjg@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.212.169
Cc: Matthew Garrett <mjg@redhat.com>
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2012 22:22:45 -0000

On 08.02.2012 17:55, Matthew Garrett wrote:
> +    if (type == GRUB_MEMORY_AVAILABLE)
> +      return 0;
> +
> +    if (target>= addr&&  target<= end)
> +      overlap = 1;
> +
> +    if (target + size>= addr&&  target + size<= end)
> +      overlap = 1;
This won't work. IEEE1275 declares only one type of memory range: 
available. Other ranges aren't declared at all.
Also it would make sense to expand this implementation to other non-efi 
platforms (pc, coreboot, ...).

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko