From: David Ahern <dsahern@gmail.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] KVM: perf: kvm events analysis tool
Date: Wed, 08 Feb 2012 20:36:20 -0700 [thread overview]
Message-ID: <4F333F34.4020007@gmail.com> (raw)
In-Reply-To: <4F333877.8050508@linux.vnet.ibm.com>
On 02/08/2012 08:07 PM, Xiao Guangrong wrote:
> Thanks for your review and explanation!
>
> The code of commit_pager_choice():
> static void commit_pager_choice(void)
> {
> switch (use_pager) {
> case 0:
> setenv("PERF_PAGER", "cat", 1);
> break;
> case 1:
> /* setup_pager(); */
> break;
> default:
> break;
> }
> }
>
> setup_pager() is not called.
>
> And it looks like kvm-events can not show the result properly if
> i try to remove setup_pager.
>
>
You're right; I blew right past the fact that it is a comment.
prev parent reply other threads:[~2012-02-09 3:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 13:06 [PATCH v3 0/3] KVM: perf: a smart tool to analyse kvm events Xiao Guangrong
2012-02-07 13:07 ` [PATCH 1/3] KVM: x86: export svm/vmx exit-code definitions to userspace Xiao Guangrong
2012-02-07 13:08 ` [PATCH v3 2/3] KVM: x86: add tracepoints to trace mmio begin and complete Xiao Guangrong
2012-02-07 13:08 ` [PATCH v3 3/3] KVM: perf: kvm events analysis tool Xiao Guangrong
2012-02-07 17:55 ` David Ahern
2012-02-08 6:14 ` Xiao Guangrong
2012-02-08 14:26 ` David Ahern
2012-02-09 3:07 ` Xiao Guangrong
2012-02-09 3:36 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F333F34.4020007@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@infradead.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=stefanha@gmail.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.