From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RvMNL-00018j-Ji
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 00:16:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RvMNK-0000er-ES
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 00:16:55 -0500
Received: from plane.gmane.org ([80.91.229.3]:35938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RvMNK-0000eb-84
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 00:16:54 -0500
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RvMNI-0004wg-Kt
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 06:16:52 +0100
Received: from 213.33.220.118 ([213.33.220.118])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 09 Feb 2012 06:16:52 +0100
Received: from e.voevodin by 213.33.220.118 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 09 Feb 2012 06:16:52 +0100
From: Evgeny Voevodin <e.voevodin@samsung.com>
Date: Thu, 09 Feb 2012 09:16:42 +0400
Message-ID: <4F3356BA.9080000@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Broken realview
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, Dmitry Solodkiy <d.solodkiy@samsung.com>

Since last QOM patch set landed into master, realview-pbx-a9, 
realview-eb-mpcore (suppose that other too) abort with error:

qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' 
failed.
Aborted


Bisect result:

9b170e60adc6dc01564128cf09f96ec923ed6526 is the first bad commit
commit 9b170e60adc6dc01564128cf09f96ec923ed6526
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Feb 2 12:51:44 2012 +0100

     qdev: access properties via QOM

     Do not poke anymore in the struct when accessing qdev properties.
     Instead, ask the object to set the right value.

     Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

-- 
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com