From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 5/5] drm/vgem: properly implement mmap Date: Thu, 09 Feb 2012 10:18:03 +0100 Message-ID: <4F338F4B.8090301@bwidawsk.net> References: <1328743171-13750-1-git-send-email-ben@bwidawsk.net> <1328743171-13750-6-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 834419E74E for ; Thu, 9 Feb 2012 01:19:03 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 02/09/2012 12:36 AM, Chris Wilson wrote: > On Thu, 9 Feb 2012 00:19:31 +0100, Ben Widawsky wrote: >> Mostly copied from i915 gtt mmaps, this will properly fault in pages as >> the user tries to use them. The only thing of note are that no >> prefaulting occurs, so perhaps some kind of madvise will happen later if >> needed. > > What's the goal here? Why not copy the simpler (from the driver > perspective) CPU mmaps? I presume that this will be required for dmabuf > in some form? > -Chris > That was what everyone seemed to want from the original RFC. I think Eric said something about helping out valgrind. I don't recall the other reasons.