Re: [Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too

[Avi Kivity <avi@redhat.com>]

On 02/09/2012 09:58 AM, Paolo Bonzini wrote:
> On 02/08/2012 04:27 PM, Avi Kivity wrote:
>> +static void core_log_stop(MemoryListener *listener,
>> +                          MemoryRegionSection *section)
>> +{
>> +}
>> +
>> +static void core_log_sync(MemoryListener *listener,
>> +                          MemoryRegionSection *section)
>> +{
>> +}
>> +
>
> Why not wrapping the calls inside an "if" so that these dummy
> functions need not be there?  Can be done in a follow-up, though.

I dislike that style.  We could have memory.c provide default versions
for users to put into their listener structures.

-- 
error compiling committee.c: too many arguments to function