From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RvRwv-0005ay-Mx for mharc-grub-devel@gnu.org; Thu, 09 Feb 2012 06:14:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:35176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvRwt-0005ae-5e for grub-devel@gnu.org; Thu, 09 Feb 2012 06:14:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvRwo-0008CY-DK for grub-devel@gnu.org; Thu, 09 Feb 2012 06:13:59 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:38794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvRwo-00088v-5f for grub-devel@gnu.org; Thu, 09 Feb 2012 06:13:54 -0500 Received: by wgbdt13 with SMTP id dt13so1141601wgb.30 for ; Thu, 09 Feb 2012 03:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lRV2TTdarV3eDeHvoeumEJhAx+8dOkaLqHy6QENcG4s=; b=HOn+U98WUhnVgzCEQRh2pWBAzRpLga0HhBdHnWP0hFgMainGsAAmm3xHXWtUdootBr aMNg9B6/Kqov+xdFuKNtfX1ZcfSI/KZbt+x3sKFhlF4Q2nNWcYAfh2032BVvTCH+d+4l UBM+yIzASFhrebQxbd7tjq2t1sXc1Mfdo1pjo= Received: by 10.216.134.5 with SMTP id r5mr519771wei.39.1328786033100; Thu, 09 Feb 2012 03:13:53 -0800 (PST) Received: from debian.x201.phnet (227-101.62-81.cust.bluewin.ch. [81.62.101.227]) by mx.google.com with ESMTPS id n5sm6809908wiw.7.2012.02.09.03.13.50 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Feb 2012 03:13:51 -0800 (PST) Message-ID: <4F33AA6C.8060101@gmail.com> Date: Thu, 09 Feb 2012 12:13:48 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: grub 1.99 add own module / dep problem References: <4F33963E.1070406@informatik.hu-berlin.de> In-Reply-To: <4F33963E.1070406@informatik.hu-berlin.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 Cc: Robert Schumann X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2012 11:14:00 -0000 On 09.02.2012 10:47, Robert Schumann wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Heyho guys! > > I'm sorry if I didn't RTFM somewhere but I just couldn't find _any_ > information on how to correctly add/patch own modules into the grub > 1.99. The problem: > > 1. mymod.c depends on a function in biosdisk.c Avoid this as much as possible. Biosdisk is arch-specific, use generic disk functions. > 2. mymod.c includes the biosdisk.h header correctly I suppose > 3. I patched grub-core/Makefile.core.def with > > module = { > name = mymod; > common = mymod/mymod.c; > enable = biosdisk; enable=i386_pc; not biosdisk > }; > > 4. I patched grub-core/Makefile.core.am with basically a copy from the > hello.c module stuff (although I should probably take the arch > dependend definitions from biosdisk mod? but I'm building i386 so it > should work any way?) Don't touch this file. Just rerun ./autogen.sh > > 5. ./configure&& make works as expected for another module which > doesn't include a foreign function. > > 6. For mymod.c I receive > mymod/mymod.c:68: error: implicit declaration of function > 'grub_biosdisk_get_diskinfo_standard' This function is static ("private"). Moreover it's for very old C/H/S addressing. Looks like you're going the wrong way. Can you detail what's your end goal? > which is of course in biosdisk.c. Now my question: How do I solve this > mystery on a code/patch base? ;) I know that I can add the biosdisk.c > to the common code functions, but that shouldn't be necessary, huh? I > thought that enable = biosdisk would do the trick with linked > functions, but well... maybe you could shed some light on it. Dependencies are tracked automatically. > > Cheers > Robert > > - -- > > |-------------------------------------------------address-+ > | work: jacob-und-wilhelm-grimm-zentrum > | geschwister-scholl-str. 1, 10117 berlin > | mail: humboldt-universität zu berlin > | computer- und medienservice > | unter den linden 6, 10099 berlin > |-------------------------------------------------contact-+ > | mail: schumann@informatik.hu-berlin.de > | icq: 93163687 | xmpp: betulichergutmensch@gmail.com > | fb: fb.com/rschumann | phone: +49(0)30-2093-70133 > |-------------------------------------------------gpg/pgp-+ > | key: remembrance.de/gpg/0xA5A5FAA2.asc > | fprnt: 9220-9732-7390-7A0C-5623-3336-4233-FDF8-A5A5-FAA2 > |---------------------------------------------------------+ > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAk8zljkACgkQQjP9+KWl+qLypgCfb6Hbwo8YwvjTbGg7h9BVKZJd > QNQAoLSsg7RhpsZ/ovACGkuO42JpZozI > =oLeZ > -----END PGP SIGNATURE----- > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko