From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvTD2-0002uv-JC
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:34:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvTD0-0008Ry-KG
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:34:44 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49578 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvTD0-0008Ro-Ff
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:34:42 -0500
Message-ID: <4F33BD5F.3040901@suse.de>
Date: Thu, 09 Feb 2012 13:34:39 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1328767876-357-1-git-send-email-peter.maydell@linaro.org>
	<201202091215.52550.paul@codesourcery.com>
In-Reply-To: <201202091215.52550.paul@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties
 before init, not after
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Evgeny Voevodin <e.voevodin@samsung.com>, patches@linaro.org, qemu-devel@nongnu.org, Dmitry Solodkiy <d.solodkiy@samsung.com>, pbonzini@redhat.com

Am 09.02.2012 13:15, schrieb Paul Brook:
>> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
>> were accidentally trying to set one of the arm_sysctl properties
>> after device init. This has now become a fatal error; set the property
>> before device init where it should be done instead.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> If somebody would like to commit this simple patch quickly that would
>> probably be a good idea since these models are otherwise totally broke=
n...
>=20
> Done.

Your commit should've contained Paolo's Reviewed-by tag after Peter's
SoB, and you as committer didn't sign it off either.

http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3D7a65c8cc315c76bde6d69284=
5c12e7ba06f44f89

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg