All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] AHCI: Fix port reset race
Date: Thu, 09 Feb 2012 15:42:28 +0100	[thread overview]
Message-ID: <4F33DB54.7080707@redhat.com> (raw)
In-Reply-To: <1327962588-5230-2-git-send-email-agraf@suse.de>

Am 30.01.2012 23:29, schrieb Alexander Graf:
> bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio
> that is currently in flight finish. So what we do is:
> 
>   port reset
>   detect ncq in flight
>   cancel ncq
>   delete ncq sg list
> 
> at which point we have double freed the sg list. Instead, with this
> patch we do:
> 
>   port reset
>   detect ncq in flight
>   cancel ncq
>   check if we are really still in flight
>   delete ncq sg list
> 
> which makes things work and gets rid of the race.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Thanks, applied to the block branch.

Kevin

  reply	other threads:[~2012-02-09 14:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 22:29 [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop Alexander Graf
2012-01-30 22:29 ` [Qemu-devel] [PATCH] AHCI: Fix port reset race Alexander Graf
2012-02-09 14:42   ` Kevin Wolf [this message]
2012-01-30 22:29 ` [Qemu-devel] [PATCH] AHCI: Masking of IRQs actually masks them Alexander Graf
2012-02-09 14:41   ` Kevin Wolf
2012-02-09 14:52     ` Alexander Graf
2012-02-07 14:57 ` [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop Andreas Färber
2012-02-07 15:01   ` Alexander Graf
2012-02-09 14:28 ` Kevin Wolf
2012-02-09 14:49   ` Alexander Graf
2012-02-09 14:59     ` Kevin Wolf
2012-02-09 15:01       ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F33DB54.7080707@redhat.com \
    --to=kwolf@redhat.com \
    --cc=agraf@suse.de \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.