From: "H. Peter Anvin" <hpa@zytor.com>
To: Hitoshi Mitake <h.mitake@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
Kashyap Desai <Kashyap.Desai@lsi.com>,
Len Brown <lenb@kernel.org>, Ravi Anand <ravi.anand@qlogic.com>,
Vikas Chaudhary <vikas.chaudhary@qlogic.com>,
Matthew Garrett <mjg@redhat.com>,
Jason Uhlenkott <juhlenko@akamai.com>,
James Bottomley <James.Bottomley@parallels.com>,
Thomas Gleixner <tglx@linutronix.de>,
Roland Dreier <roland@purestorage.com>,
James Bottomley <jbottomley@parallels.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] asm-generic: architecture independent readq/writeq for 32bit environment
Date: Thu, 09 Feb 2012 06:45:35 -0800 [thread overview]
Message-ID: <4F33DC0F.7090704@zytor.com> (raw)
In-Reply-To: <CAMO-S2h-maRLhkX255XX=TPrMH5d5F_3w-aJr7g=GRHcQ+LAXg@mail.gmail.com>
On 02/09/2012 05:37 AM, Hitoshi Mitake wrote:
> On Tue, Feb 7, 2012 at 12:47, hpanvin@gmail.com<hpa@zytor.com> wrote:
>> Should be volatile u64 * not volatile void *...
>
> Is this the type of parameters?
> The parameters of atomic readq/writeq defined in arch/x86/include/asm/io.h
> are defined as void *. I think that atomic readq/writeq and non-atomic
> readq/writeq
> should have same typed parameters and return values.
>
That sounds like a bug.
-hpa
next prev parent reply other threads:[~2012-02-09 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 2:45 [PATCH] asm-generic: architecture independent readq/writeq for 32bit environment Hitoshi Mitake
2012-02-07 3:47 ` hpanvin@gmail.com
2012-02-09 13:37 ` Hitoshi Mitake
2012-02-09 14:45 ` H. Peter Anvin [this message]
2012-02-16 4:39 ` Hitoshi Mitake
2012-02-16 5:59 ` hpanvin@gmail.com
2012-02-16 7:09 ` Hitoshi Mitake
[not found] <CA+55aFwc+VvFyv3TJgZ+wZVz738sWA+csi3_u5AeZG4AiXn82g@mail.gmail.com>
2012-02-08 16:14 ` Hitoshi Mitake
2012-02-08 16:28 ` Linus Torvalds
2012-02-09 10:58 ` Geert Uytterhoeven
2012-02-09 13:40 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33DC0F.7090704@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@parallels.com \
--cc=Kashyap.Desai@lsi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=h.mitake@gmail.com \
--cc=jbottomley@parallels.com \
--cc=juhlenko@akamai.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=ravi.anand@qlogic.com \
--cc=roland@purestorage.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.