From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvWjO-0002qv-JA
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:20:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvWjH-0002lU-Hr
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:20:22 -0500
Received: from cantor2.suse.de ([195.135.220.15]:36175 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RvWjH-0002lQ-7K
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:20:15 -0500
Message-ID: <4F33F23D.9000606@suse.de>
Date: Thu, 09 Feb 2012 17:20:13 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1324998680-16003-1-git-send-email-avi@redhat.com>
	<4EF9EF17.4050703@suse.de>
In-Reply-To: <4EF9EF17.4050703@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] softfloat: fix for C99
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

Am 27.12.2011 17:15, schrieb Andreas F=E4rber:
> Am 27.12.2011 16:11, schrieb Avi Kivity:
>> C99 appears to consider compound literals as non-constants, and compla=
ins
>> when they are used in static initializers.  Switch to ordinary initial=
izer
>> syntax.
>>

Reported-by: Andreas F=E4rber <andreas.faerber@web.de>

>> Signed-off-by: Avi Kivity <avi@redhat.com>
>=20
> Acked-by: Andreas F=E4rber <afaerber@suse.de>
>=20
> For the record, tested with --extra-cflags=3D-std=3Dgnu99.
>=20
>> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
>> index c5e2dab..4902450 100644
>> --- a/fpu/softfloat-specialize.h
>> +++ b/fpu/softfloat-specialize.h
>> @@ -89,8 +89,8 @@ const float64 float64_default_nan =3D const_float64(=
LIT64( 0xFFF8000000000000 ));
>>  #define floatx80_default_nan_low  LIT64( 0xC000000000000000 )
>>  #endif
>> =20
>> -const floatx80 floatx80_default_nan =3D make_floatx80(floatx80_defaul=
t_nan_high,
>> -                                                    floatx80_default_=
nan_low);
>> +const floatx80 floatx80_default_nan
>> +    =3D make_floatx80_init(floatx80_default_nan_high, floatx80_defaul=
t_nan_low);
>=20
> Calling it init_floatx80 would avoid the line break, but I'm okay with
> it either way.

Ping! Avi, you didn't indicate whether you were going to simplify this
patch or whether you're waiting for someone to apply it as is?

Regards,
Andreas

>=20
> Thanks,
> Andreas
>=20
>=20
> $ gcc --version
> gcc (SUSE Linux) 4.6.2
> Copyright (C) 2011 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is=
 NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP=
OSE.

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg