From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>
Subject: Re: 8250 move broke the build on sparc
Date: Thu, 9 Feb 2012 17:36:53 -0500 [thread overview]
Message-ID: <4F344A85.4070005@windriver.com> (raw)
In-Reply-To: <20120209.163009.1594369939327153054.davem@davemloft.net>
On 12-02-09 04:30 PM, David Miller wrote:
>
> Commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b ("serial: group all
> the 8250 related code together") broke the build on sparc.
>
> You really can't move 8250.c around without adjusting the "" includes
> such as the one for "suncore.h".
Understood. As I mentioned earlier[1], I'd done sparc builds, but
completely missed the fact that sparc didn't have 8250 enabled
by default. Good intentions, but bad execution. Sorry about
the fallout.
>
> Simply changing "suncore.h" to "../suncore.h" fixes things, but that's
> pretty ugly if you ask me.
It only uses suncore.h for sunserial_register_minors (and unreg).
Would you like it better if I killed all ifdefs and the include
and used an incantation of weak instead? Might be cleaner....
P.
[1] https://lkml.org/lkml/2012/2/3/355
next prev parent reply other threads:[~2012-02-09 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 21:30 8250 move broke the build on sparc David Miller
2012-02-09 21:40 ` Stephen Rothwell
2012-02-09 21:54 ` Greg KH
2012-02-09 22:36 ` Paul Gortmaker [this message]
2012-02-09 22:48 ` David Miller
2012-02-09 23:48 ` Paul Gortmaker
2012-02-10 0:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F344A85.4070005@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.