Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies)

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On 2012-02-10 07:43, David Gibson wrote:
> On Thu, Feb 09, 2012 at 11:06:57AM +0100, Jan Kiszka wrote:
>> On 2012-02-09 10:58, David Gibson wrote:
>>> On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote:
>>>> Looks like the subject would warmly welcome a "kvm:" tag.
>>>>
>>>> On 2012-02-09 05:22, David Gibson wrote:
>>> [snip]
>>>>
>>>> What about naming the problem instead:
>>>>
>>>> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */
>>>
>>> Just once, it would be nice to post something to this list and get a
>>> substantive comment _before_ the bitching about minutiae.
>>>
>>> Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)==4,
>>> which includes ppc64 amongst other 64-bit hosts.
>>
>> Then state "if int is 32 bits". The comment is unfortunately not helpful
>> without the commit log.
> 
> It'd also be nice if people didn't drop me from the CC list on my own
> patches.

Sorry, that was not intentional. My mail client possibly followed a tag
like in this mail:

Mail-Followup-To: Jan Kiszka <jan.kiszka@web.de>, anthony@codemonkey.ws,
	avi@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org

I had to add you by hand to the list again. Maybe you wanna check what
is causing this on your side.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]