From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: GRUB warning level increase
Date: Fri, 10 Feb 2012 17:00:08 +0100 [thread overview]
Message-ID: <4F353F08.5000808@gmail.com> (raw)
Hello, all. I have increased the warning level in GRUB. This is done for
quicker discovery and correction of the bugs which would be otherwise
hard to track. Mostly it enabled warnings regarding guidelines which are
already followed by GRUB.
Most important one is -Wcast-align. x86 doesn't enforce any alignment
but the other platforms do. And since platform-independent code is
usually written and tested on x86, it's important to ensure that it's
properly aligned. The invariants checked by -Wcast-align give the
necessary guarantee as long as void * isn't involved.
Some code is difficult to write in a way to satisfy the warning and/or
is platform-specific, in this case #pragma exceptions can be done.
For imported code we can add -Wno-* to module cflags for less important
(mostly stylistic) warnings.
Also if some warnings are too annoying we can drop them.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
next reply other threads:[~2012-02-10 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 16:00 Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-02-12 14:25 ` GRUB warning level increase Grégoire Sutre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F353F08.5000808@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.