All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mx35pdk: Remove duplicate CPU revision and reset cause information
Date: Fri, 10 Feb 2012 17:18:14 +0100	[thread overview]
Message-ID: <4F354346.10807@denx.de> (raw)
In-Reply-To: <1328888043-16881-1-git-send-email-fabio.estevam@freescale.com>

On 10/02/2012 16:34, Fabio Estevam wrote:
> MX35PDK board does not need to print CPU revision and reset cause in board file
> because this is printed by common code when CONFIG_DISPLAY_CPUINFO is selected
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Hi Fabio,

>  	/* Print board revision */
>  	printf("Board: MX35 PDK %d.0 ", ((get_board_rev() >> 8) + 1) & 0x0F);

Now please add a \n here, because the newline is not inserted anymore.
The output with your patches is :

Board: MX35 PDK 1.0 I2C:   ready
DRAM:  256 MiB

Thanks,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2012-02-10 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 15:34 [U-Boot] [PATCH 1/2] mx35pdk: Remove duplicate CPU revision and reset cause information Fabio Estevam
2012-02-10 15:34 ` [U-Boot] [PATCH 2/2] mx35: generic: Let get_reset_cause be defined only when CONFIG_DISPLAY_CPUINFO is selected Fabio Estevam
2012-02-10 16:49   ` Stefano Babic
2012-02-10 15:57 ` [U-Boot] [PATCH 1/2] mx35pdk: Remove duplicate CPU revision and reset cause information Stefano Babic
2012-02-10 16:18 ` Stefano Babic [this message]
2012-02-10 16:29 ` [U-Boot] [PATCH v2 " Fabio Estevam
2012-02-10 16:49   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F354346.10807@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.