From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RvvfH-0008OT-Or for mharc-grub-devel@gnu.org; Fri, 10 Feb 2012 13:57:47 -0500 Received: from eggs.gnu.org ([140.186.70.92]:35538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvvfE-0008OH-IB for grub-devel@gnu.org; Fri, 10 Feb 2012 13:57:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvvfA-00019c-28 for grub-devel@gnu.org; Fri, 10 Feb 2012 13:57:44 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:49130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rvvf9-00019R-PD for grub-devel@gnu.org; Fri, 10 Feb 2012 13:57:40 -0500 Received: by wera13 with SMTP id a13so2774250wer.0 for ; Fri, 10 Feb 2012 10:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lL/2V+1ECNA3qWaHTByxYO+7nCJR8/H+68B4OkbYMMU=; b=BZySGt3i30bcJ7JYHkYbEHshe4rcoXUHCrbVZosqJKuH9xmHsf2hhDsNhbXa2CvL/0 GstguYQCuiN3DLTgeD8VJS4b8gSHKhqJ1ci19x2g64kAPZCdcpwXtN2Tb822u3av07p7 dIGKTH8bKr1Hsh9jLBEX2/SflaG6s2CxVrTD4= Received: by 10.180.90.225 with SMTP id bz1mr5059236wib.5.1328900259001; Fri, 10 Feb 2012 10:57:39 -0800 (PST) Received: from debian.x201.phnet (93-93.203-62.cust.bluewin.ch. [62.203.93.93]) by mx.google.com with ESMTPS id hb10sm20494535wib.10.2012.02.10.10.57.36 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Feb 2012 10:57:38 -0800 (PST) Message-ID: <4F35689F.40904@gmail.com> Date: Fri, 10 Feb 2012 19:57:35 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0 MIME-Version: 1.0 To: Lennart Sorensen Subject: Re: Various build failures in current bzr tree References: <20120209190204.GW27742@caffeine.csclub.uwaterloo.ca> <4F344FEE.3060809@gmail.com> <20120210154531.GA27742@caffeine.csclub.uwaterloo.ca> <4F353FA2.7070504@gmail.com> <20120210181523.GC27742@caffeine.csclub.uwaterloo.ca> In-Reply-To: <20120210181523.GC27742@caffeine.csclub.uwaterloo.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2012 18:57:46 -0000 On 10.02.2012 19:15, Lennart Sorensen wrote: > On Fri, Feb 10, 2012 at 05:02:42PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> Yes, those are annoying but important since otherwise GCC might >> misoptimise the code. > I will grab the latest code again and run the compiler and get the > exact message. > >>> Funny, the changelog says it was removed from powerpc about 3 weeks a= go >>> by you: >>> >>> 2012-01-18 Vladimir Serbinenko >>> >>> * grub-core/kern/powerpc/dl.c (grub_arch_dl_get_tramp_got_si= ze): Remove >>> set but not used variable. >> Read again: I've just removed an unused variable. > Hmm I misread it. You didn't remove grub_arch_dl_get_tramp_got_size, > just something in it. I wonder why the linker can find > grub_arch_dl_get_tramp_got_size then. > >>> Actually removing powerpc from here builds successfully and grub >>> is booting the machine, so it seems to work without it. >> It results in memory corruption. > Where should grub_arch_dl_get_tramp_got_size come from? The linker > whines about it. > > So here are errors and warnings I am seeing with a current checkout: > > gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=3D= 1 -DGRUB_LIBDIR=3D\"/usr/lib/grub\" -DLOCALEDIR=3D\"/usr/share/locale\" = -DGRUB_MACHINE_EMU=3D1 -DGRUB_MACHINE=3DPOWERPC_EMU -DGRUB_TARGET_CPU_POW= ERPC=3D1 -DGRUB_FILE=3D\"util/getroot.c\" -I. -I../.. -I. -I../.. -I../..= /include -I./include -I./grub-core/gnulib -I../../grub-core/gnulib = -g -Wall -O2 -Wall -W -Wshadow -Wold-style-declaration -Wold-st= yle-definition -Wpointer-arith -Wmissing-prototypes -Wundef -Wextra -Wadd= ress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -= Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -= Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-bo= dy -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args= -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplici= t-function-declaration -Wimplicit-int -Winit-self -Winline -Wint-to-point= er-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wm= issing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wm= issing-noreturn -Wmudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfi= eld-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-t= ype -Wsequence-point -Wshadow -Wsign-compare -Wstack-protector -Wstrict-a= liasing -Wstrict-overflow -Wswitch -Wsync-nand -Wtrigraphs -Wtype-limits= -Wundef -Wuninitialized -Wunknown-pragmas -Wunreachable-code -Wunused -W= unused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunuse= d-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwr= ite-strings -Wmissing-declarations -Wmissing-parameter-type -Wmissing-pr= ototypes -Wnested-externs -Wstrict-prototypes -Wpointer-sign -Werror -Wn= o-undef -Wno-sign-compare -Wno-unused -Wno-unused-parameter -Wno-redundan= t-decls -Wno-unreachable-code -Wno-conversion -Wno-old-style-definition = -c -o util/libgrubkern_a-getroot.o `test -f 'util/getroot.c= ' || echo '../../'`util/getroot.c > cc1: warnings being treated as errors > ../../util/getroot.c: In function 'find_partition': > ../../util/getroot.c:1995: error: format '%lu' expects type 'long unsig= ned int', but argument 3 has type 'grub_disk_addr_t' > ../../util/getroot.c: In function 'grub_util_biosdisk_get_grub_dev': > ../../util/getroot.c:2025: error: format '%lu' expects type 'long unsig= ned int', but argument 3 has type 'grub_disk_addr_t' > > Then after changing %lu to %llu I get: > > gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=3D= 1 -DGRUB_LIBDIR=3D\"/usr/lib/grub\" -DLOCALEDIR=3D\"/usr/share/locale\" = -DGRUB_MACHINE_EMU=3D1 -DGRUB_MACHINE=3DPOWERPC_EMU -DGRUB_TARGET_CPU_POW= ERPC=3D1 -DGRUB_FILE=3D\"util/getroot.c\" -I. -I../.. -I. -I../.. -I../..= /include -I./include -I./grub-core/gnulib -I../../grub-core/gnulib = -g -Wall -O2 -Wall -W -Wshadow -Wold-style-declaration -Wold-st= yle-definition -Wpointer-arith -Wmissing-prototypes -Wundef -Wextra -Wadd= ress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -= Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -= Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-bo= dy -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args= -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplici= t-function-declaration -Wimplicit-int -Winit-self -Winline -Wint-to-point= er-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wm= issing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wm= issing-noreturn -Wmudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfi= eld-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-t= ype -Wsequence-point -Wshadow -Wsign-compare -Wstack-protector -Wstrict-a= liasing -Wstrict-overflow -Wswitch -Wsync-nand -Wtrigraphs -Wtype-limits= -Wundef -Wuninitialized -Wunknown-pragmas -Wunreachable-code -Wunused -W= unused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunuse= d-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwr= ite-strings -Wmissing-declarations -Wmissing-parameter-type -Wmissing-pr= ototypes -Wnested-externs -Wstrict-prototypes -Wpointer-sign -Werror -Wn= o-undef -Wno-sign-compare -Wno-unused -Wno-unused-parameter -Wno-redundan= t-decls -Wno-unreachable-code -Wno-conversion -Wno-old-style-definition = -c -o util/libgrubkern_a-getroot.o `test -f 'util/getroot.c= ' || echo '../../'`util/getroot.c > cc1: warnings being treated as errors > ../../util/getroot.c: In function 'grub_find_root_devices_from_mountinf= o': > ../../util/getroot.c:448: error: assuming signed overflow does not occu= r when simplifying conditional to constant > ../../util/getroot.c:448: error: assuming signed overflow does not occu= r when simplifying conditional to constant > > I am not even sure what that one means. It's a new one to me. Try this: =3D=3D=3D modified file 'util/getroot.c' --- util/getroot.c 2012-02-10 12:17:12 +0000 +++ util/getroot.c 2012-02-10 18:48:24 +0000 @@ -372,7 +372,7 @@ grub_find_root_devices_from_mountinfo (c char *buf =3D NULL; size_t len =3D 0; char **ret =3D NULL; - int entry_len =3D 0, entry_max =3D 4; + grub_size_t entry_len =3D 0, entry_max =3D 4; struct mountinfo_entry *entries; struct mountinfo_entry parent_entry =3D { 0, 0, 0, "", "", "", "" }; int i; @@ -1991,7 +1991,7 @@ grub_util_biosdisk_get_grub_dev (const c const grub_partition_t partition) { grub_disk_addr_t part_start =3D 0; - grub_util_info ("Partition %d starts from %lu", + grub_util_info ("Partition %d starts from %" PRIuGRUB_UINT64_T, partition->number, partition->start); part_start =3D grub_partition_get_start (partition); @@ -2022,7 +2022,7 @@ grub_util_biosdisk_get_grub_dev (const c return 0; } - grub_util_info ("%s starts from %lu", os_dev, start); + grub_util_info ("%s starts from %" PRIuGRUB_UINT64_T, os_dev, start)= ; if (start =3D=3D 0 && device_is_wholedisk (os_dev)) return name; > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko