From: Ben Greear <greearb@candelatech.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: r8169 crash (probably my fault) in 3.3.0-rc1+ (net-next)
Date: Fri, 10 Feb 2012 11:29:19 -0800 [thread overview]
Message-ID: <4F35700F.5010708@candelatech.com> (raw)
In-Reply-To: <4F354F51.7070202@candelatech.com>
On 02/10/2012 09:09 AM, Ben Greear wrote:
> On 02/10/2012 01:30 AM, Francois Romieu wrote:
>> Ben Greear<greearb@candelatech.com> :
>> [...]
>>> I am hacking on the 8169 code, (adding RX-ALL and RX-FCS support on top
>>> of my previously posted patches) so this could easily be my fault..
>>> but just in case someone else has seen it, please let me know....
>>
>> I have never met it before. Neither does the web.
>>
>> Are you hacking against davem's -next branch ?
>
> Yes. I was testing the attached patch, and when I enabled the rx-fcs, it crashed
> shortly after. So, my changes must be bad somehow...
>
> Probably something to do with pkt_size being 4 bytes larger when
> rx-fcs is enabled (I was hoping that would grab the FCS, as similar
> logic seems to work fine in 8139too...)
I cannot reproduce the problem, so maybe I had a funky build
or just got unlucky with some extraneous bug.
With that patch applied, rtl8169 seems to support rx-all
and rx-fcs just fine (tested with frames with bad FCS).
If/when the framework patches get accepted I'll post
the 8139too and rtl8169 patches for formal review.
Thanks,
Ben
>
> Thanks,
> Ben
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2012-02-10 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 22:20 r8169 crash (probably my fault) in 3.3.0-rc1+ (net-next) Ben Greear
2012-02-10 9:30 ` Francois Romieu
2012-02-10 17:09 ` Ben Greear
2012-02-10 19:29 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F35700F.5010708@candelatech.com \
--to=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.