Re: [PATCH 4/6] ARM: EXYNOS: Add hsotg device for NURI board

[Tushar Behera <tushar.behera@linaro.org>]

On 02/10/2012 04:05 PM, Lukasz Majewski wrote:
> From: Joonyoung Shim <jy0922.shim@samsung.com>
> 
> This patch adds hsotg device to the NURI board.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> [Rebased on the newest git/kgene/linux-samsung #for-next]
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
>  arch/arm/mach-exynos/mach-nuri.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 165c876..cd90ef2 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -43,6 +43,7 @@
>  #include <plat/fb.h>
>  #include <plat/sdhci.h>
>  #include <plat/ehci.h>
> +#include <plat/udc-hs.h>
>  #include <plat/clock.h>
>  #include <plat/gpio-cfg.h>
>  #include <plat/iic.h>
> @@ -391,6 +392,7 @@ static struct regulator_consumer_supply __initdata max8997_ldo1_[] = {
>  	REGULATOR_SUPPLY("vdd", "s5p-adc"), /* Used by CPU's ADC drv */
>  };
>  static struct regulator_consumer_supply __initdata max8997_ldo3_[] = {
> +	REGULATOR_SUPPLY("vusb_d", "s3c-hsotg"), /* USB */
>  	REGULATOR_SUPPLY("vdd11", "s5p-mipi-csis.0"), /* MIPI */
>  };
>  static struct regulator_consumer_supply __initdata max8997_ldo4_[] = {
> @@ -403,7 +405,7 @@ static struct regulator_consumer_supply __initdata max8997_ldo7_[] = {
>  	REGULATOR_SUPPLY("dig_18", "0-001f"), /* HCD803 */
>  };
>  static struct regulator_consumer_supply __initdata max8997_ldo8_[] = {
> -	REGULATOR_SUPPLY("vusb_d", NULL), /* Used by CPU */
> +	REGULATOR_SUPPLY("vusb_a", "s3c-hsotg"), /* USB */
>  	REGULATOR_SUPPLY("vdac", NULL), /* Used by CPU */
>  };
>  static struct regulator_consumer_supply __initdata max8997_ldo11_[] = {
> @@ -1115,6 +1117,9 @@ static void __init nuri_ehci_init(void)
>  	s5p_ehci_set_platdata(pdata);
>  }
>  
> +/* USB OTG */
> +static struct s3c_hsotg_plat nuri_hsotg_pdata;
> +
>  /* CAMERA */
>  static struct regulator_consumer_supply cam_vdda_supply[] = {
>  	REGULATOR_SUPPLY("a_sensor", "0-001f"),
> @@ -1268,6 +1273,7 @@ static struct platform_device *nuri_devices[] __initdata = {
>  	&exynos4_device_pd[PD_LCD0],
>  	&exynos4_device_pd[PD_CAM],
>  	&s5p_device_fimc_md,
> +	&s3c_device_usb_hsotg,
>  
>  	/* NURI Devices */
>  	&nuri_gpio_keys,
> @@ -1312,6 +1318,7 @@ static void __init nuri_machine_init(void)
>  	nuri_camera_init();
>  
>  	nuri_ehci_init();
> +	s3c_hsotg_set_platdata(&nuri_hsotg_pdata);
>  	clk_xusbxti.rate = 24000000;
>  
>  	/* Last */
It is missing S3C_DEV_USB_HSOTG entry in Kconfig file for individual boards.

Additionally, after adding the same, the build fails with following
error message.

arch/arm/plat-samsung/devs.c:1442:8: error: ‘IRQ_OTG’ undeclared here
(not in a function)
drivers/usb/gadget/s3c-hsotg.c:38:27: fatal error: mach/regs-sys.h: No
such file or directory
compilation terminated.

I had applied the patches at kgene's for-next branch while doing this
build-test.


-- 
Tushar Behera