From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Jennings Subject: Re: linux-next: build failure after merge of the final tree (staging tree related) Date: Mon, 13 Feb 2012 08:48:05 -0600 Message-ID: <4F3922A5.5030502@linux.vnet.ibm.com> References: <20120213171949.262e0c12e8d8883e90216df1@canb.auug.org.au> <20120213064508.GD28617@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e1.ny.us.ibm.com ([32.97.182.141]:35541 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167Ab2BMOtp (ORCPT ); Mon, 13 Feb 2012 09:49:45 -0500 Received: from /spool/local by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Feb 2012 09:49:44 -0500 In-Reply-To: <20120213064508.GD28617@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Nitin Gupta On 02/13/2012 12:45 AM, Greg KH wrote: > On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote: >> Hi , >> >> After merging the final tree, today's linux-next build (powerpc allyesconfig) >> failed like this: >> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier': >> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration] >> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default] >> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration] >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object': >> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration] >> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object': >> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration] >> >> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory >> allocation library"). This needs to include linux/vmalloc.h at least. I >> couldn't find set_pte at all or __flush_tlb_one for powerpc. >> >> This was too hard to revert, so I have left powerpc allyesconfig broken >> for today. I may revert it (and some dependent commits) tomorrow. > > Nitin, please send me a patch to fix this as soon as possible. Sending a patch now. Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal note, it also adds an X86 dependency since set_pte and __flush_tlb_one are x86 only. I'm working to find portable replacements for these functions. -- Seth