From: "Andreas Färber" <afaerber@suse.de>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h
Date: Mon, 13 Feb 2012 17:49:23 +0100 [thread overview]
Message-ID: <4F393F13.5000503@suse.de> (raw)
In-Reply-To: <20120213153333.28730.60650.stgit@ginnungagap.bsc.es>
Am 13.02.2012 16:33, schrieb Lluís Vilanova:
> Provides a file naming scheme consistent with other targets.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-m68k/helper.c | 2 +-
> target-m68k/helper.h | 54 +++++++++++++++++++++++++++++++++++++++++++++++
> target-m68k/helpers.h | 54 -----------------------------------------------
> target-m68k/op_helper.c | 2 +-
> target-m68k/translate.c | 6 +++--
> 5 files changed, 59 insertions(+), 59 deletions(-)
> create mode 100644 target-m68k/helper.h
> delete mode 100644 target-m68k/helpers.h
Please check your git options, it did not recognize that you're renaming
the file. Or did you also reformat it?
Is there any particular reason for these three patches beyond
aesthetics? Header names are purely target-specific choices here and do
not simplify, e.g., any Makefile logic.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-13 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 15:33 [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h Lluís Vilanova
2012-02-13 16:49 ` Andreas Färber [this message]
2012-02-13 17:01 ` Lluís Vilanova
2012-02-13 17:56 ` Andreas Färber
2012-02-13 21:41 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F393F13.5000503@suse.de \
--to=afaerber@suse.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.