From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [RFCv2 PATCH 0/5] virtual GEM provider Date: Mon, 13 Feb 2012 19:14:58 -0500 Message-ID: <4F39A782.9040205@redhat.com> References: <1328743171-13750-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 054B79F6B5 for ; Mon, 13 Feb 2012 16:14:58 -0800 (PST) In-Reply-To: <1328743171-13750-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 2/8/12 6:19 PM, Ben Widawsky wrote: > Incorporated some of the feedback given to Adam's original patch. > > My intention is to use this to do some dmabuf work/testing with i915 > since it seemed too difficult to get some of Dave Airlie's stuff > working, and I really don't feel like learning anything about nouveau if > I can avoid it. (though I plan to do that later as well). > > I think what's missing is a shrinker, left in size for mmap (didn't see > anyone respond to Daniel Vetter's comment), munmap/remap probably won't > work, do quite a bit more testing; that's all I can think of at the > moment. munmap appears to work. However if you do it after the close() you segfault at at exit. That's probably suboptimal. From an API perspective this is certainly enough for llvmpipe, and I can work around munmap being quirky for now. Reviewed-by: Adam Jackson - ajax