All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tasslehoff Kjappfot <tasskjapp@gmail.com>
To: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: [PATCH v2] i2c: fix missing handling of errata I2C_OMAP3_1P153
Date: Tue, 14 Feb 2012 11:15:55 +0100	[thread overview]
Message-ID: <4F3A345B.2060308@gmail.com> (raw)
In-Reply-To: <1329213583-20839-1-git-send-email-tasskjapp@gmail.com>

Sorry about the bad mails. First time I use git send-email to follow up 
on a patch, and it seems I need to read up a bit more on it.

Anyway.

This patch is tested on our custom board based on Beagleboard rev C3.

 From 7c1e2c14bccb16c20dc7d93088b12ac6e6e351a3 Mon Sep 17 00:00:00 2001
From: Tasslehoff Kjappfot <tasskjapp@gmail.com>
Date: Mon, 6 Feb 2012 14:14:23 +0100
Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153

i2c_prope set the dev->errata flag, but omap_i2c_init cleared the flag 
again. Move the errata handling to i2c_probe.

Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
---
  drivers/i2c/busses/i2c-omap.c |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 801df60..d609ae2 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
  	/* Take the I2C module out of reset: */
  	omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);

-	dev->errata = 0;
-
-	if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207)
-		dev->errata |= I2C_OMAP_ERRATA_I207;
-
  	/* Enable interrupts */
  	dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY |
  			OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK |
@@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev)

  	dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff;

+	dev->errata = 0;
+
+	if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207)
+		dev->errata |= I2C_OMAP_ERRATA_I207;
+
  	if (dev->rev <= OMAP_I2C_REV_ON_3430)
  		dev->errata |= I2C_OMAP3_1P153;

-- 
1.7.5.4



  reply	other threads:[~2012-02-14 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 14:33 [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 tasskjapp
2012-02-09 11:37 ` Tasslehoff Kjappfot
2012-02-11 17:18 ` Shubhrajyoti
2012-02-14  8:55   ` Tasslehoff Kjappfot
     [not found] ` <1328538811-13097-1-git-send-email-tasskjapp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-14  9:59   ` Tasslehoff Kjappfot
2012-02-14 10:15     ` Tasslehoff Kjappfot [this message]
2012-02-16 11:36       ` [PATCH v2] " Shubhrajyoti Datta
2012-02-17 12:19         ` [PATCH v3] " Tasslehoff Kjappfot
2012-02-17 12:40           ` Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3A345B.2060308@gmail.com \
    --to=tasskjapp@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.