From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Zhi Yong Wu <zwu.kernel@gmail.com>, Stefan Weil <sw@weilnetz.de>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable
Date: Tue, 14 Feb 2012 06:46:17 -0600 [thread overview]
Message-ID: <4F3A5799.2090306@codemonkey.ws> (raw)
In-Reply-To: <CAJSP0QWDjaaae2XcRbRgnZHJKG+K0GnG0r5uFt_VXLww3A7=Eg@mail.gmail.com>
On 02/13/2012 05:16 AM, Stefan Hajnoczi wrote:
> On Mon, Feb 13, 2012 at 6:29 AM, Stefan Weil<sw@weilnetz.de> wrote:
>> Allocating RAM for the emulated machine is perhaps the only
>> scenario where a core dump is indeed not reasonable. In most
>> other cases, out-of-memory is an indication of a QEMU internal
>> problem, so a core dump should be written.
>
> Allocating guest memory could fail and we should give a reasonable
> error and exit with a failure. I think this might be the one case
> where we *do* want to handle memory allocation NULL return. In other
> words, perhaps we should call memory allocating functions directly
> here instead of using the typical QEMU abort-on-failure wrappers.
g_try_malloc
glib already has a suite of functions for this.
Regards,
Anthony Liguori
>
> Stefan
>
next prev parent reply other threads:[~2012-02-14 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 14:34 [Qemu-devel] [PATCH] oslib: make error handling more reasonable Zhi Yong Wu
2012-02-10 14:41 ` Daniel P. Berrange
2012-02-10 15:13 ` Zhi Yong Wu
2012-02-10 15:53 ` Stefan Weil
2012-02-13 2:37 ` Zhi Yong Wu
2012-02-13 6:29 ` Stefan Weil
2012-02-13 11:16 ` Stefan Hajnoczi
2012-02-14 12:46 ` Anthony Liguori [this message]
2012-02-14 12:45 ` Anthony Liguori
2012-02-13 14:04 ` Markus Armbruster
2012-02-13 14:30 ` Peter Maydell
2012-02-14 12:42 ` Paul Brook
2012-02-14 12:46 ` Daniel P. Berrange
2012-02-14 13:07 ` Paul Brook
2012-02-14 12:47 ` Anthony Liguori
2012-02-10 18:35 ` Eric Blake
2012-02-13 2:42 ` Zhi Yong Wu
2012-02-13 9:17 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A5799.2090306@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.