From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxLcx-0002Up-E2
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 11:53:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxLcn-0001RE-Th
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 11:53:15 -0500
Received: from goliath.siemens.de ([192.35.17.28]:27272)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxLcn-0001Qx-Es
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 11:53:05 -0500
Message-ID: <4F3A9161.7020907@siemens.com>
Date: Tue, 14 Feb 2012 17:52:49 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4F333AAA.1070601@cn.fujitsu.com> <4F333BA3.70006@cn.fujitsu.com>
In-Reply-To: <4F333BA3.70006@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a
 physical address is I/O address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Eric Blake <eblake@redhat.com>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 2012-02-09 04:21, Wen Congyang wrote:
> This API will be used in the following patch.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  cpu-common.h |    2 ++
>  exec.c       |   16 ++++++++++++++++
>  2 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu-common.h b/cpu-common.h
> index a40c57d..d047137 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -71,6 +71,8 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
>  void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
>  void cpu_unregister_map_client(void *cookie);
>  
> +bool is_io_addr(target_phys_addr_t phys_addr);

Something like cpu_physical_memory_is_io would be more consistent with
other APIs around.

> +
>  /* Coalesced MMIO regions are areas where write operations can be reordered.
>   * This usually implies that write operations are side-effect free.  This allows
>   * batching which can make a major impact on performance when using
> diff --git a/exec.c b/exec.c
> index b81677a..edc5684 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -4435,3 +4435,19 @@ bool virtio_is_big_endian(void)
>  #undef env
>  
>  #endif
> +
> +bool is_io_addr(target_phys_addr_t phys_addr)
> +{
> +    ram_addr_t pd;
> +    PhysPageDesc p;
> +
> +    p = phys_page_find(phys_addr >> TARGET_PAGE_BITS);
> +    pd = p.phys_offset;
> +
> +    if (!is_ram_rom_romd(pd)) {

return !is_ram_rom_romd(pd); ?

> +        /* I/O region */
> +        return true;
> +    }
> +
> +    return false;
> +}

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux