From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RxVMF-0007ze-De
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 22:16:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RxVME-0000RC-2S
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 22:16:39 -0500
Received: from [222.73.24.84] (port=50177 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RxVMD-0000Qc-Ho
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 22:16:38 -0500
Message-ID: <4F3B2078.3030703@cn.fujitsu.com>
Date: Wed, 15 Feb 2012 11:03:20 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4F333AAA.1070601@cn.fujitsu.com> <4F333BA3.70006@cn.fujitsu.com>
	<4F3A9161.7020907@siemens.com>
In-Reply-To: <4F3A9161.7020907@siemens.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a
 physical address is I/O address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Eric Blake <eblake@redhat.com>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

At 02/15/2012 12:52 AM, Jan Kiszka Wrote:
> On 2012-02-09 04:21, Wen Congyang wrote:
>> This API will be used in the following patch.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>>  cpu-common.h |    2 ++
>>  exec.c       |   16 ++++++++++++++++
>>  2 files changed, 18 insertions(+), 0 deletions(-)
>>
>> diff --git a/cpu-common.h b/cpu-common.h
>> index a40c57d..d047137 100644
>> --- a/cpu-common.h
>> +++ b/cpu-common.h
>> @@ -71,6 +71,8 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
>>  void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
>>  void cpu_unregister_map_client(void *cookie);
>>  
>> +bool is_io_addr(target_phys_addr_t phys_addr);
> 
> Something like cpu_physical_memory_is_io would be more consistent with
> other APIs around.

Do you mean change the API's name? If so, I will change it.

> 
>> +
>>  /* Coalesced MMIO regions are areas where write operations can be reordered.
>>   * This usually implies that write operations are side-effect free.  This allows
>>   * batching which can make a major impact on performance when using
>> diff --git a/exec.c b/exec.c
>> index b81677a..edc5684 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -4435,3 +4435,19 @@ bool virtio_is_big_endian(void)
>>  #undef env
>>  
>>  #endif
>> +
>> +bool is_io_addr(target_phys_addr_t phys_addr)
>> +{
>> +    ram_addr_t pd;
>> +    PhysPageDesc p;
>> +
>> +    p = phys_page_find(phys_addr >> TARGET_PAGE_BITS);
>> +    pd = p.phys_offset;
>> +
>> +    if (!is_ram_rom_romd(pd)) {
> 
> return !is_ram_rom_romd(pd); ?

Yes, I will change the code.

Thanks
Wen Congyang

> 
>> +        /* I/O region */
>> +        return true;
>> +    }
>> +
>> +    return false;
>> +}
> 
> Jan
>