All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sh: Add bit control functions
Date: Wed, 15 Feb 2012 08:56:25 +0100	[thread overview]
Message-ID: <4F3B6529.5090802@denx.de> (raw)
In-Reply-To: <1329292203-27855-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello Nobuhiro,

Nobuhiro Iwamatsu wrote:
> This provide bit control functions as clrbits_*, setbits_* and
> clrsetbits_*.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  arch/sh/include/asm/io.h |   37 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 37 insertions(+), 0 deletions(-)

Beside one minor comment:

Acked-by: Heiko Schocher <hs@denx.de>

> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
> index ca598a6..79cb098 100644
> --- a/arch/sh/include/asm/io.h
> +++ b/arch/sh/include/asm/io.h
> @@ -237,6 +237,43 @@ static inline void sync(void)
>  {
>  }
>  
> +
> +/* Clear and set bits in one shot. These macros can be used to clear and

Wrong comment style, please fix.

[...]

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2012-02-15  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15  7:50 [U-Boot] [PATCH] sh: Add bit control functions Nobuhiro Iwamatsu
2012-02-15  7:56 ` Heiko Schocher [this message]
2012-02-22  1:16   ` Nobuhiro Iwamatsu
  -- strict thread matches above, loose matches on Subject: below --
2012-02-22  1:19 Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B6529.5090802@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.