From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Hoyer Subject: Re: [PATCH 2/3] wait_for_if_up fix Date: Wed, 15 Feb 2012 09:22:50 +0100 Message-ID: <4F3B6B5A.6070007@redhat.com> References: <20120215064027.GA30110@darkstar.nay.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120215064027.GA30110-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Dave Young Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Am 15.02.2012 07:40, schrieb Dave Young: > wait_for_if_up will always return 0, fix it by change to use =~ to > check if link state is up > > Signed-off-by: Dave Young > --- > modules.d/99base/dracut-lib.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh > index 6b70adf..85d4925 100755 > --- a/modules.d/99base/dracut-lib.sh > +++ b/modules.d/99base/dracut-lib.sh > @@ -385,7 +385,7 @@ wait_for_if_up() { > local cnt=0 > while [ $cnt -lt 200 ]; do > li=$(ip link show $1) > - [ -z "${li##*state UP*}" ] && return 0 > + [[ "$li" =~ "state UP" ]] && return 0 > sleep 0.1 > cnt=$(($cnt+1)) > done This is not posix shell compliant. $ PS1="$ " dash $ li="my state DOWN test" $ [ -z "${li##*state UP*}" ] && echo OK $ li="my state UP test" $ [ -z "${li##*state UP*}" ] && echo OK OK $ works for me