From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Tejun Heo <tj@kernel.org>, Vivek Goyal <vgoyal@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Knut Petersen <Knut_Petersen@t-online.de>,
mroos@linux.ee, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags
Date: Wed, 15 Feb 2012 09:43:11 +0100 [thread overview]
Message-ID: <4F3B701F.6050703@kernel.dk> (raw)
In-Reply-To: <CANejiEVmBOJ7ggD1O6tbXhvZAzZCa6VCi4D421Kqnszx_6QL-Q@mail.gmail.com>
On 2012-02-15 02:09, Shaohua Li wrote:
> 2012/2/15 Tejun Heo <tj@kernel.org>:
>> icq->changed was used for ICQ_*_CHANGED bits. Rename it to flags and
>> access it under ioc->lock instead of using atomic bitops.
>> ioc_get_changed() is added so that the changed part can be fetched and
>> cleared as before.
>>
>> icq->flags will be used to carry other flags.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> ---
>> Jens, these three patches are to fix the swap heavy workload
>> regression reported by Shaohua.
>>
>> Shaohua, I ended up changing the second patch, which shouldn't change
>> anything but it would be great if you can verify this series once
>> more.
> yes, confirmed the patches fix the regression. Thanks for fixing it.
> Tested-by: Shaohua Li <shaohua.li@intel.com>
Great, thanks Tejun - and Shaohua for finding/reporting/testing. I'll
get this applied.
--
Jens Axboe
prev parent reply other threads:[~2012-02-15 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 18:12 [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags Tejun Heo
2012-02-14 18:16 ` [PATCH block/for-linus 2/3] block: simplify ioc_release_fn() Tejun Heo
2012-02-14 18:17 ` [PATCH block/for-linus 3/3] block: exit_io_context() should call elevator_exit_icq_fn() Tejun Heo
2012-02-15 1:09 ` [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags Shaohua Li
2012-02-15 8:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3B701F.6050703@kernel.dk \
--to=axboe@kernel.dk \
--cc=Knut_Petersen@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=shaohua.li@intel.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.