From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxbTO-0005kw-Il for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:48:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxbTI-00025o-3N for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:48:26 -0500 Received: from fmmailgate05.web.de ([217.72.192.243]:60158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxbTH-00025X-Rd for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:48:20 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate05.web.de (Postfix) with ESMTP id B237069B53ED for ; Wed, 15 Feb 2012 10:48:18 +0100 (CET) Message-ID: <4F3B7F60.1060503@web.de> Date: Wed, 15 Feb 2012 10:48:16 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1329293521-16197-1-git-send-email-zwu.kernel@gmail.com> <4F3B6D1F.9010607@web.de> <20120215093800.GB30825@redhat.com> In-Reply-To: <20120215093800.GB30825@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDAF36456A141D30D7A443FCC" Subject: Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: zwu.kernel@gmail.com, Zhi Yong Wu , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDAF36456A141D30D7A443FCC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-02-15 10:38, Michael S. Tsirkin wrote: > On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote: >> On 2012-02-15 09:12, zwu.kernel@gmail.com wrote: >>> From: Zhi Yong Wu >>> >>> Signed-off-by: Zhi Yong Wu >>> --- >>> slirp/if.c | 2 -- >>> 1 files changed, 0 insertions(+), 2 deletions(-) >>> >>> diff --git a/slirp/if.c b/slirp/if.c >>> index 2852396..8e0cac2 100644 >>> --- a/slirp/if.c >>> +++ b/slirp/if.c >>> @@ -8,8 +8,6 @@ >>> #include >>> #include "qemu-timer.h" >>> =20 >>> -#define ifs_init(ifm) ((ifm)->ifs_next =3D (ifm)->ifs_prev =3D (ifm)= ) >>> - >>> static void >>> ifs_insque(struct mbuf *ifm, struct mbuf *ifmhead) >>> { >> >> Let's grab the chance and move ifs_init to mbuf.h. >> >> Jan >> >=20 > Since you mention it - why does slirp have all these > defines in the first place? >=20 > slirp/mbuf.h:#define m_nextpkt m_hdr.mh_nextpkt > slirp/mbuf.h:#define ifs_next m_nextpkt >=20 > Seriously, #define for a field name? > This is just crazy, and violates our coding style > which requires macros to be PPER_CAS_WITH_UNDERSCORES >=20 This is a total mess, I agree, and I'd warmly welcome patches to clean this up. I can only speculate on the reasons. Maybe the intention was to keep the core minimally modified and wrap all the conflicts it causes away. Given that slirp outside QEMU is dead, this is no longer a valid reason (if it ever was). Jan --------------enigDAF36456A141D30D7A443FCC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk87f2AACgkQitSsb3rl5xRFkQCgqJKfvb/OmPm5LjXlJ+BhCQCs lHAAoNiQZycv3rqhebZp5T0bjDSs+FDr =GZSx -----END PGP SIGNATURE----- --------------enigDAF36456A141D30D7A443FCC--