From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxeiy-00037F-JK for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:16:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rxeir-0007d1-Qu for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:16:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxeir-0007cr-KL for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:16:37 -0500 Message-ID: <4F3BB031.5040601@redhat.com> Date: Wed, 15 Feb 2012 14:16:33 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328902266-25308-1-git-send-email-lcapitulino@redhat.com> <1328902266-25308-5-git-send-email-lcapitulino@redhat.com> <4F3B7532.6050902@redhat.com> <20120215110556.29af67b9@doriath.home> In-Reply-To: <20120215110556.29af67b9@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On 02/15/2012 02:05 PM, Luiz Capitulino wrote: >> > QDicts should be constant once they've >> > been built. > I think you meant QErrors? I meant QDicts included in Errors. > > (Also, I would refcount Errors rather than copy them, but > > that's a personal preference and I do not really object to error_copy). > The Error object doesn't have refcounts and I'd prefer to just duplicate it > for now (instead of adding it). Yes, that's fine. Paolo