All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wido den Hollander <wido@widodh.nl>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: logrotate and auto start = no
Date: Wed, 15 Feb 2012 15:26:23 +0100	[thread overview]
Message-ID: <4F3BC08F.7090106@widodh.nl> (raw)

Hi,

When "auto start = no" is set for the OSD's, the logs won't get rotated.

I've set this to no so I can easily reboot machines without all OSD's 
starting, I think it's easier with testing or when you replace a broken 
disk.

Anyway, this prevents the logs from being rotated, causing my disks to 
fill up:

/var/log/ceph/*.log {
     rotate 7
     daily
     compress
     sharedscripts
     postrotate
         invoke-rc.d ceph reload >/dev/null || service ceph reload 
 >/dev/null
     endscript
     missingok
}

The init script doesn't touch daemons which have auto start set to no, 
but this also prevents logrotate from doing it's job.

Some suggestions:

1. Don't use the init script for logrotation
2. Modify the init script
3. Add a note in the documentation about this behaviour

I think that logrotation should work regardless the setting of auto start?

What do you think?

Wido

             reply	other threads:[~2012-02-15 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 14:26 Wido den Hollander [this message]
2012-02-15 14:40 ` logrotate and auto start = no Sage Weil
2012-02-15 15:20   ` [PATCH] init: Only check if auto start is disabled when the issued command is "start" Wido den Hollander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3BC08F.7090106@widodh.nl \
    --to=wido@widodh.nl \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.