Re: [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table()

[Vitaliy Gusev <gusev.vitaliy@nexenta.com>]

On 02/15/2012 07:01 PM, Adamson, Andy wrote:
>
> No, commit aacd5537270a752fe12a9914a207284fc2341c6d initializes and resets the slot tables with the ivalue
> which is 1 for the forechannel and 0 for the back channel, just as in 3.2.


nfs4_init_slot_table() doesn't use ivalue at all.



>
> To be clear from aacd5537:
>
> -static int nfs4_init_slot_tables(struct nfs4_session *session)
> +static int nfs4_setup_session_slot_tables(struct nfs4_session *ses)
>   {
>          struct nfs4_slot_table *tbl;
> -       int status = 0;
> +       int status;
>
> -       tbl =&session->fc_slot_table;
> +       dprintk("-->  %s\n", __func__);
> +       /* Fore channel */
> +       tbl =&ses->fc_slot_table;
>          if (tbl->slots == NULL) {
> -               status = nfs4_init_slot_table(tbl,
> -                               session->fc_attrs.max_reqs, 1);
>                                                                               ^^^^^^^
>                                                                               ivalue of 1
>