From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be drained regardless of q->elevator
Date: Wed, 15 Feb 2012 16:57:48 +0100 [thread overview]
Message-ID: <4F3BD5FC.30101@kernel.dk> (raw)
In-Reply-To: <20120214011427.GJ12117@google.com>
On 2012-02-14 02:14, Tejun Heo wrote:
> Currently, blk_cleanup_queue() doesn't call elv_drain_elevator() if
> q->elevator doesn't exist; however, bio based drivers don't have
> elevator initialized but can still use blk-throttle. This patch moves
> q->elevator test inside blk_drain_queue() such that only
> elv_drain_elevator() is skipped if !q->elevator.
>
> -v2: loop can have registered queue which has NULL request_fn. Make
> sure we don't call into __blk_run_queue() in such cases.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Vivek Goyal <vgoyal@redhat.com>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> Added check against NULL q->request_fn for loop driver. Thanks.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2012-02-15 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 22:52 [PATCH block/for-linus] block: blk-throttle should be drained regardless of q->elevator Tejun Heo
2012-02-13 23:27 ` Vivek Goyal
2012-02-13 23:40 ` Tejun Heo
2012-02-15 15:53 ` Vivek Goyal
2012-02-14 1:14 ` [PATCH UPDATED " Tejun Heo
2012-02-15 15:57 ` Vivek Goyal
2012-02-15 15:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3BD5FC.30101@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.