All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] slirp: kill ugly macros
Date: Wed, 15 Feb 2012 19:55:47 +0100	[thread overview]
Message-ID: <4F3BFFB3.5000806@siemens.com> (raw)
In-Reply-To: <20120215184515.GA32249@redhat.com>

On 2012-02-15 19:45, Michael S. Tsirkin wrote:
> Remove ugly macros for field names,
> change done by the following script:
> 
> s#\bifq_prev\b#m_prev#g;
> s#\bifq_next\b#m_next#g;
> s#\bifs_prev\b#m_prevpkt#g;
> s#\bifs_next\b#m_nextpkt#g;
> s#\bifq_so\b#m_so#g;
> s#\bm_next\b#m_hdr.mh_next#g;
> s#\bm_prev\b#m_hdr.mh_prev#g;
> s#\bm_nextpkt\b#m_hdr.mh_nextpkt#g;
> s#\bm_prevpkt\b#m_hdr.mh_prevpkt#g;
> s#\bm_flags\b#m_hdr.mh_flags#g;
> s#\bm_len\b#m_hdr.mh_len#g;
> s#\bm_data\b#m_hdr.mh_data#g;
> s#\bm_size\b#m_hdr.mh_size#g;
> s#\bm_dat\b#M_dat.m_dat_#g;
> s#\bm_ext\b#M_dat.m_ext_#g;

Could you convert M_dat to m_dat as well (do not script, it's also a
type)? It looks strange.

Thanks in any case!
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-02-15 18:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 18:45 [Qemu-devel] [PATCH] slirp: kill ugly macros Michael S. Tsirkin
2012-02-15 18:55 ` Jan Kiszka [this message]
2012-02-16 11:06   ` Kevin Wolf
2012-02-16 11:09     ` Peter Maydell
2012-02-16 11:17       ` Kevin Wolf
2012-02-17 13:32     ` Jan Kiszka
2012-02-16 11:52   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3BFFB3.5000806@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.