All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Brian Norris <computersforpeace@gmail.com>,
	Lin Ming <ming.m.lin@intel.com>,
	Norbert Preining <preining@logic.at>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org,
	"stern@rowland.harvard.edu >> Alan Stern"
	<stern@rowland.harvard.edu>,
	linux-ide@vger.kernel.org,
	Linux PM mailing list <linux-pm@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Jian Peng <jipeng2005@gmail.com>,
	Kevin Cernekee <cernekee@gmail.com>,
	valdis.kletnieks@vt.edu, Mark Lord <kernel@teksavvy.com>
Subject: Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed
Date: Wed, 15 Feb 2012 14:18:07 -0500	[thread overview]
Message-ID: <4F3C04EF.7070404@garzik.org> (raw)
In-Reply-To: <20120215183139.GC24986@google.com>

On 02/15/2012 01:31 PM, Tejun Heo wrote:
> Hey, Jeff.
>
> On Wed, Feb 15, 2012 at 01:29:29PM -0500, Jeff Garzik wrote:
>> A module parameter is not necessarily the best/only option.
>> ahci_platform already has infrastructure set up to deal with
>> platform-specific quirks.  An internal flag seems more appropriate
>> to enable automatic handling of this on the specific platforms where
>> it applies (plus the revert Tejun has already mentioned).
>
> The problem is that there's no way to identify the controller in
> question, so we can't do this automatically, so might just as well do
> it in the simplest way for now.  :(

See ahci_devtype[] and ahci_port_info[] in ahci_platform.c for how to do 
this.  Brian would not have to tweak the driver out of tree as claimed; 
we put all changes in tree, and the platform calls itself 
"spec-strict-ahci" or whatever string you prefer.

	Jeff




  reply	other threads:[~2012-02-15 19:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02  5:12 Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed Norbert Preining
2012-02-02  8:38 ` Srivatsa S. Bhat
2012-02-03  1:15   ` Lin Ming
2012-02-03  4:21     ` Lin Ming
2012-02-03  5:24       ` Norbert Preining
2012-02-03  5:34         ` Lin Ming
2012-02-03  5:43           ` Norbert Preining
2012-02-03  8:27             ` Lin Ming
2012-02-06  0:46               ` Norbert Preining
2012-02-06  1:36                 ` Lin Ming
2012-02-06  2:40                   ` Norbert Preining
2012-02-06  2:49                     ` Lin Ming
2012-02-06  3:15                       ` Norbert Preining
2012-02-06  4:42                         ` Lin Ming
2012-02-06 16:19                           ` Tejun Heo
2012-02-06 19:20                             ` Brian Norris
2012-02-06 22:46                               ` Norbert Preining
2012-02-08  9:10                               ` Valdis.Kletnieks
2012-02-13 17:44                               ` Tejun Heo
2012-02-15  5:15                                 ` Brian Norris
2012-02-15 16:57                                   ` Tejun Heo
2012-02-15 18:29                                     ` Jeff Garzik
2012-02-15 18:31                                       ` Tejun Heo
2012-02-15 19:18                                         ` Jeff Garzik [this message]
2012-02-15 23:39                                           ` Brian Norris
2012-02-16 16:22                                             ` Jeff Garzik
2012-02-16 14:20                                         ` Mark Lord
2012-02-16 16:19                                           ` Jeff Garzik
2012-02-03  4:29     ` Norbert Preining
2012-02-03  4:29     ` Norbert Preining

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3C04EF.7070404@garzik.org \
    --to=jeff@garzik.org \
    --cc=cernekee@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=jipeng2005@gmail.com \
    --cc=kernel@teksavvy.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=preining@logic.at \
    --cc=rjw@sisk.pl \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.