From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37447)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RxkeM-0005HR-9T
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 14:36:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RxkeL-00062y-1E
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 14:36:22 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:55188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RxkeK-00062s-Ro
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 14:36:20 -0500
Received: by qabg40 with SMTP id g40so3365599qab.4
	for <qemu-devel@nongnu.org>; Wed, 15 Feb 2012 11:36:20 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4F3C0930.7010407@twiddle.net>
Date: Wed, 15 Feb 2012 11:36:16 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <CAAu8pHvEDw_3mrdYh7xPtHJGcejpdNruWKWZux3WEQECzn228g@mail.gmail.com>
In-Reply-To: <CAAu8pHvEDw_3mrdYh7xPtHJGcejpdNruWKWZux3WEQECzn228g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] i386: Remove REGPARM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 02/15/2012 10:11 AM, Blue Swirl wrote:
>  #if defined(CONFIG_SOFTMMU)
> -    int mem_index, s_bits, arg_idx;
> +    int mem_index, s_bits;
> +#if TCG_TARGET_REG_BITS == 64
> +    int arg_idx;
> +#else
> +    int stack_adjust;
> +#endif

...

> -    if (TCG_TARGET_REG_BITS == 64) {
> -        tcg_out_mov(s, (opc == 3 ? TCG_TYPE_I64 : TCG_TYPE_I32),
...
> +#if TCG_TARGET_REG_BITS == 32
> +    tcg_out_pushi(s, mem_index);

Any particular reason you didn't continue with the C-if form,
so that you could avoid the extra ifdeffery at the top there?


r~