All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: alexandermurashkin@msn.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH] Use posix_memalign() for memory used to write bitmaps
Date: Thu, 16 Feb 2012 09:01:15 +0100	[thread overview]
Message-ID: <4F3CB7CB.5020505@redhat.com> (raw)
In-Reply-To: <20120216141735.4065bf8a@notabene.brown>

On 02/16/12 04:17, NeilBrown wrote:
> On Tue, 14 Feb 2012 11:52:13 +0100 Jes.Sorensen@redhat.com wrote:
> 
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This makes super[01].c properly align buffers used for the bitmap
>> using posix_memalign() to make sure the writes don't fail in case the
>> bitmap is opened using O_DIRECT.
>>
>> This is based on https://bugzilla.redhat.com/show_bug.cgi?id=789898
>> and an initial patch by Alexander Murashkin.
> 
> hi Jes,
> 
> I suspect that
> 
> http://neil.brown.name/git?p=mdadm;a=commitdiff;h=6ef89052d85b8137b8a7100f761d896ae6f61001
> 
> is the fix you want.  But I'll probably apply yours as well.
> 
> Thanks,
> NeilBrown

Hi Neil,

Thanks, I haven't been able to reproduce the problem locally that
Alexander was seeing, but I suspect you are right. That said, I'd still
vote in favor of using posix_memalign() rather than doing the pointer
juggling, less error prone.

Cheers,
Jes

      reply	other threads:[~2012-02-16  8:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 10:52 [PATCH] Use posix_memalign() for memory used to write bitmaps Jes.Sorensen
2012-02-16  3:17 ` NeilBrown
2012-02-16  8:01   ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3CB7CB.5020505@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=alexandermurashkin@msn.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.