All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Bug 932487 <932487@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)
Date: Thu, 16 Feb 2012 11:34:16 +0100	[thread overview]
Message-ID: <4F3CDBA8.1090407@redhat.com> (raw)
In-Reply-To: <CAJSP0QXEoBB2GQeUTKaKvSgqzF+ny7bzM0GDQ8KnDuPXtKVunQ@mail.gmail.com>

Am 16.02.2012 10:34, schrieb Stefan Hajnoczi:
> This is interesting because the code is a straightforward usage of
> coroutines:
> 
> co = qemu_coroutine_create(bdrv_rw_co_entry);
> qemu_coroutine_enter(co, &rwco);   <--- boom
> 
> Please make test-coroutine and try ./test-coroutine.  That performs
> some sanity checks.
> 
> I haven't had time to look in depth yet but perhaps this worked in the
> past and you could bisect it to find the commit that broke it?

Remember that I saw a similar crash a while ago? It was definitely a
NULL pointer access somewhere inside SwitchToFiber. I can't remember
exactly what came out of it, but I think you and Paolo couldn't
reproduce it and I ran out of time for debugging win32 stuff.

If I was to debug this, the first thing I would try is that I would dump
co->fiber (or actually I seem to remember it was some data structure
that is only pointed to by a field in co->fiber) immediately after the
coroutine is created (I think it was still okay then) and set a
watchpoint on it.

Kevin

  reply	other threads:[~2012-02-16 10:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15  1:59 [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue) Roy Tam
2012-02-15  7:15 ` [Qemu-devel] [Bug 932487] " Roy Tam
2012-02-16  9:34 ` [Qemu-devel] [Bug 932487] [NEW] " Stefan Hajnoczi
2012-02-16 10:34   ` Kevin Wolf [this message]
2012-02-16 10:56     ` Roy Tam
2012-02-16 11:01     ` Paolo Bonzini
2012-02-16 11:15       ` Kevin Wolf
2012-02-16 13:13         ` Roy Tam
2012-02-16 16:05           ` Paolo Bonzini
2012-02-16 20:31 ` [Qemu-devel] [Bug 932487] " Stefan Weil
2012-02-16 20:42 ` Stefan Weil
2012-02-17  0:53   ` Roy Tam
2012-02-17  1:00     ` Roy Tam
2012-02-27 16:04     ` Paolo Bonzini
2012-02-27 15:17 ` Eric Lassauge
2012-03-20  6:38 ` Roy Tam
2012-03-20  9:07 ` Stefan Weil
2012-03-20  9:35   ` Roy Tam
2012-03-20  9:57     ` Paolo Bonzini
2016-12-11  7:19 ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3CDBA8.1090407@redhat.com \
    --to=kwolf@redhat.com \
    --cc=932487@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.