From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxzSw-00053c-K8 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:25:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxzSq-0007Ft-R3 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:25:34 -0500 Received: from goliath.siemens.de ([192.35.17.28]:28641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxzSq-0007Fh-Fn for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:25:28 -0500 Message-ID: <4F3CE7A5.30600@siemens.com> Date: Thu, 16 Feb 2012 12:25:25 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1329347774-23262-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: "qemu-devel@nongnu.org" , "gleb@redhat.com" On 2012-02-16 00:16, Igor Mammedov wrote: > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > of sysbus. So we can support APIC hot-plug feature. > > This is repost of original patch for qemu-kvm rebased on current qemu: > http://lists.nongnu.org/archive/html/qemu-devel/2011-11/msg01478.html > All credits to Liu Ping Fan for writing it. > > V2 changes: > - cpusockets_init: cpu_sockets is not yet initialized, use cpus that > we got as input param instead for qbus_create, this makes cpus > apics visible in "info qtree" monitor command > - fix format error spotted by Jan and missed by checkpatch > - cpu_has_apic_feature: return bool instead of int > This patch surely no longer applies. And the ICC requires QOM conversion. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux