From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry01l-0005Sq-Ft for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:01:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry01d-0005KS-EV for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:01:33 -0500 Received: from goliath.siemens.de ([192.35.17.28]:29427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry01d-0005KM-2G for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:01:25 -0500 Message-ID: <4F3CF010.1040607@siemens.com> Date: Thu, 16 Feb 2012 13:01:20 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1329347774-23262-3-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: "qemu-devel@nongnu.org" , "gleb@redhat.com" On 2012-02-16 00:16, Igor Mammedov wrote: > +static ICCBusDeviceInfo cpu_device_info = { > + .qdev.name = "cpu-pc", > + .qdev.size = sizeof(CPUPC), > + .qdev.reset = cpu_device_reset, > + .init = cpu_device_init, > + .qdev.props = (Property[]) { > + DEFINE_PROP_STRING("model", CPUPC, model), And how do you pass in feature flags? Or the core layout? Basically both -cpu and -smp need to be expressible via multiple "-device cpu-x86,xxx" (not "pc") commands. As a shortcut, "-smp N" would continue to replicate a "-device cpu-XX" N times. Otherwise, configuration becomes inconsistent. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux