From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: Fix exposure of ARM_EXYNOS4210_CPUFREQ Date: Thu, 16 Feb 2012 21:17:30 +0900 Message-ID: <4F3CF3DA.7000806@samsung.com> References: <20120213094940.GA15338@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=CFQaKI5CaN53xLHaKcvmTI3VZniKBCc9gf+HHIYPnVM=; b=Qj4N9A/JQ0+2Mkpn9EP8UzzorZxtu1vwt6T8EduiUvZsWrISOvD9dZUwyB/17x3TuY lcFcJsCLEwBsJlhAM9C6wq5wDGQ7lfvQFfI7YZuw+kUBTSCyrESys5ahEAvJAISSvUSv NVaDMLVFfyocee+4rlH9AggtuwnWOXNV7yN6Y= In-Reply-To: <20120213094940.GA15338@n2100.arm.linux.org.uk> Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, Dave Jones , cpufreq@vger.kernel.org, Kukjin Kim On 02/13/12 18:49, Russell King - ARM Linux wrote: > From: Russell King > > exynos4210-cpufreq.c is not buildable on non-exynos builds, so it's > pointless allowing this option to be exposed. Fix this by adding a > dependency on ARCH_EXYNOS. > > drivers/cpufreq/exynos4210-cpufreq.c:20:29: error: mach/regs-clock.h: No such file or directory > drivers/cpufreq/exynos4210-cpufreq.c:21:26: error: mach/cpufreq.h: No such file or directory > > Signed-off-by: Russell King > Cc: Dave Jones > Cc: cpufreq@vger.kernel.org > Cc: Kukjin Kim > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index e0664fe..c8bde43 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -34,6 +34,7 @@ config ARM_EXYNOS_CPUFREQ > > config ARM_EXYNOS4210_CPUFREQ > bool "Samsung EXYNOS4210" > + depends on ARCH_EXYNOS > help > This adds the CPUFreq driver for Samsung EXYNOS4210 > SoC (S5PV310 or S5PC210). > Yes, you're right. Should be added it. BTW, how about following? diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index e0664fe..a5e0487 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -33,7 +33,7 @@ config ARM_EXYNOS_CPUFREQ If in doubt, say N. config ARM_EXYNOS4210_CPUFREQ - bool "Samsung EXYNOS4210" + bool help This adds the CPUFreq driver for Samsung EXYNOS4210 SoC (S5PV310 or S5PC210). I think, when selecting "ARM_EXYNOS_CPUFREQ", "ARM_EXYNOS4210_CPUFREQ" will be selected on EXYNOS4210 with above changes. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Thu, 16 Feb 2012 21:17:30 +0900 Subject: [CPUFREQ] Fix exposure of ARM_EXYNOS4210_CPUFREQ In-Reply-To: <20120213094940.GA15338@n2100.arm.linux.org.uk> References: <20120213094940.GA15338@n2100.arm.linux.org.uk> Message-ID: <4F3CF3DA.7000806@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/13/12 18:49, Russell King - ARM Linux wrote: > From: Russell King > > exynos4210-cpufreq.c is not buildable on non-exynos builds, so it's > pointless allowing this option to be exposed. Fix this by adding a > dependency on ARCH_EXYNOS. > > drivers/cpufreq/exynos4210-cpufreq.c:20:29: error: mach/regs-clock.h: No such file or directory > drivers/cpufreq/exynos4210-cpufreq.c:21:26: error: mach/cpufreq.h: No such file or directory > > Signed-off-by: Russell King > Cc: Dave Jones > Cc: cpufreq at vger.kernel.org > Cc: Kukjin Kim > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index e0664fe..c8bde43 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -34,6 +34,7 @@ config ARM_EXYNOS_CPUFREQ > > config ARM_EXYNOS4210_CPUFREQ > bool "Samsung EXYNOS4210" > + depends on ARCH_EXYNOS > help > This adds the CPUFreq driver for Samsung EXYNOS4210 > SoC (S5PV310 or S5PC210). > Yes, you're right. Should be added it. BTW, how about following? diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index e0664fe..a5e0487 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -33,7 +33,7 @@ config ARM_EXYNOS_CPUFREQ If in doubt, say N. config ARM_EXYNOS4210_CPUFREQ - bool "Samsung EXYNOS4210" + bool help This adds the CPUFreq driver for Samsung EXYNOS4210 SoC (S5PV310 or S5PC210). I think, when selecting "ARM_EXYNOS_CPUFREQ", "ARM_EXYNOS4210_CPUFREQ" will be selected on EXYNOS4210 with above changes. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.