All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akio Idehara <zbe64533@gmail.com>
To: seth.forshee@canonical.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ALPS touchpad detection
Date: Thu, 16 Feb 2012 21:47:50 +0900	[thread overview]
Message-ID: <4F3CFAF6.1090507@gmail.com> (raw)
In-Reply-To: <20120215161855.GA2495@ubuntu-macmini>

Thank you for commenting.
I'll send the new one.

Seth Forshee wrote:
> On Wed, Feb 15, 2012 at 09:58:25PM +0900, Akio Idehara wrote:
>> ALPS touchpad detection fails if some buttons of ALPS are pressed.
>> The reason is that the query response byte is different from what is expected.
>> This was tested on a Toshiba Portege R500.
>
> I've reproduced the problem and confirmed that your approach fixes it.
>
> However, your patch seems to be malformed as it won't apply cleanly for
> me. For the comment you're modifying you should also keep the line
> length under 80 characters.
>
> This fix seems like a good candidate for stable as well.
>
> Seth


      reply	other threads:[~2012-02-16 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 12:58 [PATCH] Fix ALPS touchpad detection Akio Idehara
2012-02-15 16:18 ` Seth Forshee
2012-02-16 12:47   ` Akio Idehara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3CFAF6.1090507@gmail.com \
    --to=zbe64533@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.