From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0nK-0000RR-F8 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:50:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry0nC-0006E1-Hz for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:50:42 -0500 Received: from david.siemens.de ([192.35.17.14]:15304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0nC-0006Dn-6c for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:50:34 -0500 Message-ID: <4F3CFB96.1000505@siemens.com> Date: Thu, 16 Feb 2012 13:50:30 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-2-git-send-email-imammedo@redhat.com> <4F3CE7A5.30600@siemens.com> <4F3CF9AE.5020701@codemonkey.ws> In-Reply-To: <4F3CF9AE.5020701@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Igor Mammedov , "qemu-devel@nongnu.org" , "gleb@redhat.com" On 2012-02-16 13:42, Anthony Liguori wrote: > On 02/16/2012 05:25 AM, Jan Kiszka wrote: >> On 2012-02-16 00:16, Igor Mammedov wrote: >>> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >>> CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead >>> of sysbus. So we can support APIC hot-plug feature. >>> >>> This is repost of original patch for qemu-kvm rebased on current qemu: >>> http://lists.nongnu.org/archive/html/qemu-devel/2011-11/msg01478.html >>> All credits to Liu Ping Fan for writing it. >>> >>> V2 changes: >>> - cpusockets_init: cpu_sockets is not yet initialized, use cpus that >>> we got as input param instead for qbus_create, this makes cpus >>> apics visible in "info qtree" monitor command >>> - fix format error spotted by Jan and missed by checkpatch >>> - cpu_has_apic_feature: return bool instead of int >>> >> >> This patch surely no longer applies. And the ICC requires QOM conversion. > > Also, post-QOM, I don't think having an ICC bus makes a whole lot of sense. > > The LAPIC can be made a child of the CPU device with a bidirectional link. We do have a bus here, the IO-APICs are attached to it as well. But we can surely save that dummy cpusockets device. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux