From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed Date: Thu, 16 Feb 2012 09:20:22 -0500 Message-ID: <4F3D10A6.8090608@teksavvy.com> References: <20120206024052.GI9413@gamma.logic.tuwien.ac.at> <1328496591.15079.40.camel@minggr> <20120206031528.GA16093@gamma.logic.tuwien.ac.at> <1328503376.15079.55.camel@minggr> <20120206161943.GA3926@google.com> <20120213174445.GD12117@google.com> <20120215165706.GA24986@google.com> <4F3BF989.8060607@garzik.org> <20120215183139.GC24986@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120215183139.GC24986@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , Brian Norris , Lin Ming , Norbert Preining , "Srivatsa S. Bhat" , linux-kernel@vger.kernel.org, "stern@rowland.harvard.edu >> Alan Stern" , linux-ide@vger.kernel.org, Linux PM mailing list , "Rafael J. Wysocki" , Jian Peng , Kevin Cernekee , valdis.kletnieks@vt.edu List-Id: linux-ide@vger.kernel.org On 12-02-15 01:31 PM, Tejun Heo wrote: > Hey, Jeff. > > On Wed, Feb 15, 2012 at 01:29:29PM -0500, Jeff Garzik wrote: >> A module parameter is not necessarily the best/only option. >> ahci_platform already has infrastructure set up to deal with >> platform-specific quirks. An internal flag seems more appropriate >> to enable automatic handling of this on the specific platforms where >> it applies (plus the revert Tejun has already mentioned). > > The problem is that there's no way to identify the controller in > question, so we can't do this automatically, so might just as well do > it in the simplest way for now. :( Well, a module parameter is no good, because that method would affect all attached controllers rather than just the one(s) with the issue. Something in sysfs perhaps.