From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry3dD-0002Qd-84 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:52:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry3d7-0006il-Aa for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:52:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51896 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry3d7-0006ie-0I for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:52:21 -0500 Message-ID: <4F3D2631.4080505@suse.de> Date: Thu, 16 Feb 2012 16:52:17 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-8-git-send-email-imammedo@redhat.com> <4F3C4146.1000905@codemonkey.ws> <4F3CCD64.3070305@redhat.com> In-Reply-To: <4F3CCD64.3070305@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: jan.kiszka@siemens.com, gleb@redhat.com, qemu-devel@nongnu.org Am 16.02.2012 10:33, schrieb Igor Mammedov: > On 02/16/2012 12:35 AM, Anthony Liguori wrote: >> On 02/15/2012 05:16 PM, Igor Mammedov wrote: >>> Adds ability to hot-add cpus if guest was started with options >>> -smp X,maxcpus=3DY >>> where X< Y. >>> For simplicity sake this implementation doesn't allow to add specific >>> cpu but rather it adds the next not yet plugged cpu. >>> >>> For adding cpu just execute following command in monitor: >>> device_add cpu-pc >>> If guest was started with a specific cpu model, then add option model >>> to cmonitor command. for example: >>> device_add cpu-pc,model=3D"host" >>> >>> Signed-off-by: Igor Mammedov >> >> I don't see how the code matches this description, but unless you've >> got qdev-ification patches in the earlier ones (haven't made the list >> yet), >> device_add is not the right place for this. > Indeed, I've attempted qdev-ify cpu first (patch 2/7) >=20 >> >> There's no such thing as "cpu-pc" either. You should start with a >> cpu_add command. > "cpu-pc" is coming from 2/7 where cpu was qdev-ifed and I needed to cal= l > it somehow. > Looking at other attempts to qdev-ify cpus i.e. "cpu-ppc", "cpu-mips", > I've just > followed trend. Is there any suggestions on how it should be called? There's a CPU QOM'ification series of mine on the list with which your series conflicts conceptually. Unfortunately due to name conflicts I can no longer incrementally post a v4 so I am converting all targets now one after another, x86 will by the current name scheme get an X86CPU (TYPE_X86_CPU). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg