From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Susi Subject: Re: [PATCH 2/2] e2image: add -a switch to include all data Date: Thu, 16 Feb 2012 19:17:55 -0500 Message-ID: <4F3D9CB3.4020704@ubuntu.com> References: <1329428112-8911-1-git-send-email-psusi@ubuntu.com> <1329428112-8911-2-git-send-email-psusi@ubuntu.com> <20120216231745.GC26473@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org To: Ted Ts'o Return-path: Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:32915 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969Ab2BQAR5 (ORCPT ); Thu, 16 Feb 2012 19:17:57 -0500 In-Reply-To: <20120216231745.GC26473@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/16/2012 06:17 PM, Ted Ts'o wrote: > As I recall Lukas disclaimed a guarantee that the code would work on > qcow2 images that weren't generated by e2image. (In particular, it > definitely doesn't support compressed or encrypted qcow2 images.) > > So we need to make sure we add the appropriate disclaimers that this > might not work on qcow2 images generated by tools other than e2image. Would you care to craft such a disclaimer? > It will only work for raw images. The QCOW2 format uses an entirely > different code path, since we don't have an QCOW2 io_manager > abstraction. That was my original hope, but that's not how our qcow2 > support was implemented, so it won't work, and we should probably give > a reasonable warning if someone tries to use the -a flag with anything > other than a raw file system image for e2image's input. It seemed to work fine with qcow2 when I tested it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPPZyzAAoJEJrBOlT6nu75U2UIAMgAF/+pIFQCiXCQGMqt+6rR 4k2P2Q/NfRIIf5lSuNaMCuV88ZuUU002ywEN6z9hPfxXDIagDAzOArtVI2nAhwfz Z4BF7uJ+7eJDCDQycNDb4JmAQDRs2sBuu3Y0dHKWthyd39KYMR7B0ARwCSeYLczB eigCiQwTVechP2jacWwNnv53BP2xbw/BYy5IHfQViSKijxGNdheQkYqOTIO5eGGB NdPx5A6yogLOHyB3K3E9cqEnAjXSlelLH7sRCPAmHmQiJVscAiNZ6JvyP/oV0uek HlmvP0LyZwzMvy8XlgoybHNRLysw+VEVVuLIrAzZJHiW7aWH3WPtqrPEQp6XoJY= =cmZg -----END PGP SIGNATURE-----