From: Johannes Sixt <j.sixt@viscovery.net>
To: jehan@orb.com
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH v2] Add a setting to require a filter to be successful
Date: Fri, 17 Feb 2012 08:08:00 +0100 [thread overview]
Message-ID: <4F3DFCD0.6070002@viscovery.net> (raw)
In-Reply-To: <4f3daaf7.e302440a.02ba.fffff463@mx.google.com>
Am 2/17/2012 2:19, schrieb jehan@orb.com:
> @@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,
...
> ret |= apply_filter(path, src, len, dst, filter);
> + if (!ret && required)
> + die("required filter '%s' failed", ca.drv->name);
Wouldn't it be much more helpful if this were:
die("%s: clean filter '%s' failed", path, ca.drv->name);
Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().
> + ! git checkout -- test.fs
test_must_fail git checkout -- test.fs
> + ! git add test.fc
test_must_fail git add test.fc
-- Hannes
next prev parent reply other threads:[~2012-02-17 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 23:18 [PATCH] Add an option to require a filter to be successful Jehan Bing
2012-02-17 0:03 ` Junio C Hamano
2012-02-17 1:19 ` [PATCH v2] Add a setting " jehan
2012-02-17 7:08 ` Johannes Sixt [this message]
2012-02-17 15:35 ` Junio C Hamano
2012-02-18 0:07 ` Junio C Hamano
2012-02-18 0:43 ` Jehan Bing
2012-02-18 7:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3DFCD0.6070002@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jehan@orb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.