From: Paolo Bonzini <pbonzini@redhat.com>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock
Date: Fri, 17 Feb 2012 09:31:43 +0100 [thread overview]
Message-ID: <4F3E106F.8060102@redhat.com> (raw)
In-Reply-To: <CAOq732LZU10Lk_dw1Hwz83Q+e2qsFM9NWEQPiASfKjcJqPXT2A@mail.gmail.com>
On 02/17/2012 09:24 AM, andrzej zaborowski wrote:
>> > Ok, then I think it's better to switch that one to vm_clock (so that you
>> > could use it as a deterministic debugging aid with -icount, for
>> > example). What do you think?
> I was thinking about potential visual effects.
vm_clock is the same as rt_clock as long as: 1) you don't use -icount;
2) you don't stop the VM.
Not pulsing the LED when the VM is stopped seems okay, so I think
switching from rt_clock to vm_clock is the right thing to do.
> But perhaps you were
> right with the first approach, i.e. debugging -> deterministic (which
> in this case would ideally also use the frequency derived from the
> system clock passed to omap_lpg_init), normal work -> realtime.
You should get this from -icount if you just use vm_clock.
The overall series doesn't apply anymore, I'll split omap_lpg into its
own patch and resend.
Paolo
next prev parent reply other threads:[~2012-02-17 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 12:06 [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM Paolo Bonzini
2012-01-20 12:06 ` [Qemu-devel] [PATCH 1/4] rtc: add -rtc clock=rt Paolo Bonzini
2012-01-20 12:06 ` [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock Paolo Bonzini
2012-02-17 7:09 ` andrzej zaborowski
2012-02-17 8:05 ` Paolo Bonzini
2012-02-17 8:24 ` andrzej zaborowski
2012-02-17 8:31 ` Paolo Bonzini [this message]
2012-01-20 12:06 ` [Qemu-devel] [PATCH 3/4] pl031: rearm alarm timer upon load Paolo Bonzini
2012-01-20 12:06 ` [Qemu-devel] [PATCH 4/4] pl031: switch clock base to rtc_clock Paolo Bonzini
2012-01-30 16:54 ` Peter Maydell
2012-01-30 17:02 ` Paolo Bonzini
2012-01-30 16:42 ` [Qemu-devel] [PATCH 0/4] Use rtc_clock uniformly for ARM Paolo Bonzini
2012-01-30 17:21 ` Peter Maydell
2012-01-31 7:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E106F.8060102@redhat.com \
--to=pbonzini@redhat.com \
--cc=balrogg@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.