From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyKKj-0002Yb-U3 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 04:42:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyKKd-0002cz-Q2 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 04:42:29 -0500 Received: from thoth.sbs.de ([192.35.17.2]:21201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyKC3-0001f6-J6 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 04:33:31 -0500 Message-ID: <4F3E1EE9.4080508@siemens.com> Date: Fri, 17 Feb 2012 10:33:29 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1329442328-13318-1-git-send-email-afaerber@suse.de> In-Reply-To: <1329442328-13318-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] kvmclock: Always register type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" On 2012-02-17 02:32, Andreas F=C3=A4rber wrote: > Currently, the "kvmclock" type is only registered when kvm_enabled(). >=20 > This breaks when moving type registration to before command line > parsing (so that QOM types can be used for CPU and machine). >=20 > Since the QOM classes are lazy-initialized anyway and kvmclock_create() > has another kvm_enabled() check, simply drop the KVM check in > kvmclock_register_types(). >=20 > kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check. >=20 > Signed-off-by: Andreas F=C3=A4rber > Cc: Jan Kiszka > Cc: Marcelo Tosatti > --- > hw/kvm/clock.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/kvm/clock.c b/hw/kvm/clock.c > index 2157340..446bd62 100644 > --- a/hw/kvm/clock.c > +++ b/hw/kvm/clock.c > @@ -121,9 +121,7 @@ void kvmclock_create(void) > =20 > static void kvmclock_register_types(void) > { > - if (kvm_enabled()) { > type_register_static(&kvmclock_info); > - } > } > =20 > type_init(kvmclock_register_types) Reviewed-by: Jan Kiszka uq/master stuff or do other changes need it earlier? --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux